Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/fife.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/fife-0.4.1-1.fc26.src.rpm Description: Flexible Isometric Free Engine (FIFE) is a multi-platform isometric game engine written in C++. It comes with Python bindings allowing users to create games using Python as well as C++. The engine is extendable and enables you to add any feature you can imagine to your project. Fedora Account System Username: ignatenkobrain
Note for reviewers: * It's unretirement review of old fife package in Fedora * To build python bindings you need fifechan >= 0.1.4 (it is available in koji already) * And yes, it will eat your memory when building ;)
Taking this review.
Failed to build in mock: /builddir/build/BUILD/fifengine-0.4.1/engine/core/video/cursor.cpp:29:10: fatal error: X11/Xcursor/Xcursor.h: No such file or directory #include <X11/Xcursor/Xcursor.h> ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. Are you sure you have all your dependencies declared?
(In reply to Neal Gompa from comment #3) > Failed to build in mock: > > /builddir/build/BUILD/fifengine-0.4.1/engine/core/video/cursor.cpp:29:10: > fatal error: X11/Xcursor/Xcursor.h: No such file or directory > #include <X11/Xcursor/Xcursor.h> > ^~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > > Are you sure you have all your dependencies declared? fixed.
+ /usr/bin/cat /builddir/build/SOURCES/0001-Removed-leftover-stuff-from-Cursor.-Refs-991.patch + /usr/bin/patch -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -------------------------- |From 400636b6fd76e1d65bd1f2e261d51486f422b3b3 Mon Sep 17 00:00:00 2001 |From: helios2000 <helios2000> |Date: Fri, 10 Feb 2017 17:22:06 +0100 |Subject: [PATCH] Removed leftover stuff from Cursor. Refs #991 I see no reason | to keep XCursor and WMCursor around. Cursor only needs SDL. | |--- | engine/core/video/cursor.cpp | 34 +--------------------------------- | 1 file changed, 1 insertion(+), 33 deletions(-) | |diff --git a/engine/core/video/cursor.cpp b/engine/core/video/cursor.cpp |index 5d4fd4e6..24f7f51c 100644 |--- a/engine/core/video/cursor.cpp |+++ b/engine/core/video/cursor.cpp -------------------------- File to patch: Skip this patch? [y] 2 out of 2 hunks ignored Patch doesn't apply...
git cherry-pick works without any problems when i checkout the release and then get the commit with cherry-pick.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
Since Igor removed himself from the CC list, and his Redhat email used when creating the bug is deactivated, I'm closing this as a stalled review per https://docs.fedoraproject.org/en-US/fesco/Package_review_policy/#submitter_not_responding. It looks like his level of Fedora contribution had to be reduced sometime back (https://pagure.io/fesco/issue/2858). I did send a direct email to Igor mentioning my actions here in case he'd like to take a different approach, but it doesn't seem possible for him to actually pick this up under the original reporter account, so this should clear the way for any other requester if they are interested.
By the way not long ago I found this source https://gamblizard.ca/best-canadian-online-casinos/best-payout-casino/ best payout casino, he works on a very interesting and new platform for me. Could someone help me with this one?
This comment was flagged a spam, view the edit history to see the original text if required.