Created attachment 1248881 [details] Patch for suppress warnings and improve tests Description of problem: I uploaded a patch to suppress deprecated Fixnum warnings, and improve tests as the tests file structure are changed from older version of flexmock. Version-Release number of selected component (if applicable): rubygem-flexmock-2.3.4-1 I did below tests. - License check: ok - rpmlint check: See attachment file lint.log - Install check: ok I like it will be merged.
Created attachment 1248883 [details] lint.log
I would appreciate it if you would try to make source compatible before 2.4 and make patches also acceptable by the upstream.
@jaruga: May be you did not noticed, but the upstream have changed to: https://github.com/doudou/flexmock (apparently due to the fact that the original author passed away) @mtasaka: It would be probably good idea to update the URLs in the .spec file ...
Hi, Oh I thought the upstream URL is https://github.com/jimweirich/flexmock .. I sent PR yesterday to https://github.com/jimweirich/flexmock/pull/22 .. OK I will send same kind of PR to https://github.com/doudou/flexmock.
Comment on attachment 1248881 [details] Patch for suppress warnings and improve tests I made mistake. I created the patch from old upstream repo.
Created attachment 1249019 [details] Patch for suppress warnings and improve tests
Created attachment 1249020 [details] lint.log
@mtasaka: I uploaded my patch again now, because I mistook the upstream repo to create my patch. > I would appreciate it if you would try to make source compatible before 2.4 and make patches also acceptable by the upstream. OK. The patch for upstream is here. We can wait upstream will accept the patch right now. https://github.com/doudou/flexmock/pull/5 You can see not only Ruby 2.4, but also all tests before 2.4, were passed. https://travis-ci.org/doudou/flexmock/builds/200290534 I checked below things. I also updated LICENSE and URL by following the result of `gem2rpm flexmock-2.3.4.gem`. - License check: License file is not included. Asking here. https://github.com/doudou/flexmock/issues/6 - rpmlint check: See attachment file lint.log - Install check: ok Thanks.
Created attachment 1249021 [details] Patch for suppress warnings and improve tests
Created attachment 1255870 [details] Patch for suppress warnings and improve tests 2 Hello mamoru. My patch was merged at upstream. https://github.com/doudou/flexmock/pull/5 And I uploaded my patch here again that is improved. I used `0.class` instead of `Integer`. It is better for the compatibility under Ruby 2.4. Ruby 2.4.0 ``` $ /usr/local/ruby-2.4.0/bin/irb irb(main):001:0> 0.class => Integer ``` Less than Ruby 2.4.0 ``` $ /usr/local/ruby-2.3.1/bin/irb irb(main):001:0> 0.class => Fixnum ```
(In reply to Vít Ondruch from comment #3) > @mtasaka: It would be probably good idea to update the URLs in the .spec > file ... I was referring not just to URL but also to Source0 ...
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'.
Committed. http://pkgs.fedoraproject.org/cgit/rpms/rubygem-flexmock.git/commit/?id=67b33746737e0fc2417de00fc145cbe79b0bc6dc Note that now test suite warns against minitest: se assert_nil if expecting nil from /builddir/build/BUILD/rubygem-flexmock-2.3.5/usr/share/gems/gems/flexmock-2.3.5/test/partial_mock_test.rb:142:in `test_original_behavior_can_be_restored'. This will fail in MT6.