Hide Forgot
Dockerfile URL: https://roshi.fedorapeople.org/containers/apache/Dockerfile Source URL: https://roshi.fedorapeople.org/containers/apache/ Description: Container to run apache on port 80. Fedora Account System Username: roshi
Man, the container guidelines are a breeze compared to today's packaging guidelines. See the notes below: Dockerfile Guidelines: ok - LABELs are sane MAINTAINER points to the Cloud wiki page. Should it instead point to you as the maintainer or to the Atomic SIG? ok - CMD/ENTRYPOINT is sane Container Content Guidelines: ok - No net new code run-apache.sh is sufficiently minimal ok - One service per container Naming guidelines: ok - Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ NO - Package names are sane Apache httpd goes by the name "httpd" both upstream and in Fedora. The container should match these as well. ok - No naming conflicts ok - Version is sane -- - Version does not contain ~ ok - Release is sane ok - %dist tag ok - Case used only when necessary ok - Package names follow applicable language/addon rules
Please, mind #1429680, which is also a review request for the Apache HTTPD. That variant is a bit more powerful and also runs on OpenShift, which is important for the docker images. The image from #1429680 should cover all use cases of this one as well. Would you be fine with going with #1429680 instead?
We can go with that one. I'll close this out. Thanks Honza! *** This bug has been marked as a duplicate of bug 1429680 ***