Bug 1421141 - Review Request: perl-Icon-FamFamFam-Silk - Embed FamFamFam Silk icons in your code
Summary: Review Request: perl-Icon-FamFamFam-Silk - Embed FamFamFam Silk icons in your...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1421142
TreeView+ depends on / blocked
 
Reported: 2017-02-10 13:04 UTC by Petr Pisar
Modified: 2017-02-13 09:29 UTC (History)
2 users (show)

Fixed In Version: perl-Icon-FamFamFam-Silk-0.2.1.3-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-13 09:29:14 UTC
Type: ---
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-02-10 13:04:25 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Icon-FamFamFam-Silk/perl-Icon-FamFamFam-Silk.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Icon-FamFamFam-Silk/perl-Icon-FamFamFam-Silk-0.2.1.3-1.fc26.src.rpm
Description:
This is a collection of Silk icons from <http://famfamfam.com/lab/icons/silk/>
provided in form of a Perl module.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-02-10 14:12:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Icon-FamFamFam-Silk-0.2.1.3-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(MIME::Base64)
      1 perl(URI)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Icon-FamFamFam-Silk-0.2.1.3-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Icon::FamFamFam::Silk) = 0.002001003
      1 perl-Icon-FamFamFam-Silk = 0.2.1.3-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Icon-FamFamFam-Silk*
perl-Icon-FamFamFam-Silk.noarch: W: spelling-error %description -l en_US http -> HTTP
perl-Icon-FamFamFam-Silk.src: W: spelling-error %description -l en_US http -> HTTP
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-02-10 15:08:07 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Icon-FamFamFam-Silk

Comment 3 Petr Pisar 2017-02-13 09:29:14 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.