Bug 1421147 - Suppress deprecated Fixnum warnings on Ruby 2.4.0
Summary: Suppress deprecated Fixnum warnings on Ruby 2.4.0
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-ffi
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominic Cleal
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-10 13:28 UTC by Jun Aruga
Modified: 2017-02-10 15:32 UTC (History)
5 users (show)

Fixed In Version: rubygem-ffi-1.9.14-3.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-10 15:32:10 UTC
Type: Bug


Attachments (Terms of Use)
Patch for suppress warnings (3.51 KB, patch)
2017-02-10 13:36 UTC, Jun Aruga
no flags Details | Diff
Patch for suppress warnings (2.23 KB, patch)
2017-02-10 13:37 UTC, Jun Aruga
no flags Details | Diff
lint.log (353 bytes, text/plain)
2017-02-10 13:37 UTC, Jun Aruga
no flags Details
Patch for suppress warnings (2.28 KB, patch)
2017-02-10 14:54 UTC, Jun Aruga
no flags Details | Diff

Description Jun Aruga 2017-02-10 13:28:28 UTC
Description of problem:

Suppress deprecated Fixnum warnings on Ruby 2.4.0
The patch is here.
https://github.com/ffi/ffi/pull/557
This patch has compatibility not only Ruby 2.4 but also other Ruby version < 2.4.

Version-Release number of selected component (if applicable):
rubygem-ffi-1.9.14-2

I like this will be merged.
Thanks.

Comment 1 Jun Aruga 2017-02-10 13:35:28 UTC
I did below tests.

- License check: ok
- rpmlint check: see attachment lint.log
- Install check: ok

Comment 2 Jun Aruga 2017-02-10 13:36:04 UTC
Created attachment 1249037 [details]
Patch for suppress warnings

Comment 3 Jun Aruga 2017-02-10 13:37:12 UTC
Created attachment 1249038 [details]
Patch for suppress warnings

Comment 4 Jun Aruga 2017-02-10 13:37:32 UTC
Created attachment 1249039 [details]
lint.log

Comment 5 Dominic Cleal 2017-02-10 13:40:08 UTC
(In reply to Jun Aruga from comment #3)
> Created attachment 1249038 [details]
> Patch for suppress warnings

re https://bugzilla.redhat.com/attachment.cgi?id=1249038&action=diff#a/rubygem-ffi.spec_sec2

Why is the suggested patching in the %check section and not %prep? It isn't part of the test suite.

Comment 6 Jun Aruga 2017-02-10 14:33:59 UTC
@Dominic you are correct. I made mistake..

Just moment. I will upload the patch again here.

Comment 7 Jun Aruga 2017-02-10 14:54:28 UTC
Created attachment 1249051 [details]
Patch for suppress warnings

Uploaded again.
Can you check it again?

Comment 8 Dominic Cleal 2017-02-10 15:32:10 UTC
Thanks, merged as 1b59849 and building.


Note You need to log in before you can comment on or make changes to this bug.