Bug 1421166 - Review Request: perl-Config-ZOMG - Catalyst::Plugin::ConfigLoader-style layer over Config::Any
Summary: Review Request: perl-Config-ZOMG - Catalyst::Plugin::ConfigLoader-style layer...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-10 14:16 UTC by Petr Pisar
Modified: 2017-02-13 15:11 UTC (History)
2 users (show)

Fixed In Version: perl-Config-ZOMG-1.000000-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-13 15:11:52 UTC
Type: ---
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-02-10 14:16:20 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Config-ZOMG/perl-Config-ZOMG.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Config-ZOMG/perl-Config-ZOMG-1.000000-1.fc26.src.rpm
Description:
Config::ZOMG is a fork of Config::JFDI. It removes a couple of unusual
features and passes the same tests three times faster than Config::JFDI.

Config::ZOMG is an implementation of Catalyst::Plugin::ConfigLoader. It will
scan a directory for files matching a certain name. If such a file is found
which also matches an extension that Config::Any can read, then the
configuration from that file will be loaded.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-02-13 13:31:12 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Config-ZOMG-1.000000-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Clone)
      1 perl(Config::Any)
      1 perl(Config::ZOMG::Source::Loader)
      1 perl(Hash::Merge::Simple)
      1 perl(List::Util)
      1 perl(Moo)
      1 perl(Sub::Quote)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Config-ZOMG-1.000000-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Config::ZOMG) = 1.000000
      1 perl(Config::ZOMG::Source::Loader) = 1.000000
      1 perl-Config-ZOMG = 1.000000-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Config-ZOMG*
perl-Config-ZOMG.noarch: W: spelling-error Summary(en_US) ConfigLoader -> Configuration
perl-Config-ZOMG.noarch: W: spelling-error %description -l en_US ConfigLoader -> Configuration
perl-Config-ZOMG.src: W: spelling-error Summary(en_US) ConfigLoader -> Configuration
perl-Config-ZOMG.src: W: spelling-error %description -l en_US ConfigLoader -> Configuration
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

BuildRequires are ok
TODO: perl(Config::General) is optional for tests (t/12-loader-file.t,
      t/16-loader-order.t). Please consider to add it to build-requires.
      Now, it is install as dependency for perl-Config-Any.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-02-13 14:34:55 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Config-ZOMG

Comment 3 Petr Pisar 2017-02-13 15:11:52 UTC
Thank you for the review and the repository. I added the optional dependency.


Note You need to log in before you can comment on or make changes to this bug.