Dockerfile URL: https://hhorak.fedorapeople.org/toolchain-docker/Dockerfile Other files URL: https://hhorak.fedorapeople.org/toolchain-docker/ Description: This container image provides a platform for building C and C++ applications. It is a Fedora alternative to Developer Toolset Toolchain from Red Hat Software Collections. Fedora Account System Username: hhorak
Well, since we don't have any `fedora-review` nor `rpmlint`, I'll just inline-comment: > io.k8s.display-name="Fedora alternative to Developer Toolset Toolchain" I would name it as "Fedora variant of software collection Devel..." Not sure about capitals. > ADD contrib/bin/usage /usr/local/bin/usage Why don't you add it to /opt/app-root? (nitpick) I would also prefer COPY (since ADD may have side effects). > https://hhorak.fedorapeople.org/toolchain-docker/contrib/etc/scl_enable This seems redundant. I would also like to see some documentation with better examples: how would I use the container to compile my code?
Thanks for the suggestions! (In reply to Tomas Tomecek from comment #1) > > io.k8s.display-name="Fedora alternative to Developer Toolset Toolchain" > > I would name it as "Fedora variant of software collection Devel..." Hm, what about "Fedora variant of Developer Toolset's Toolchain from Software Collections" > > ADD contrib/bin/usage /usr/local/bin/usage > > Why don't you add it to /opt/app-root? (nitpick) Reported in https://github.com/sclorg/devtoolset-container/issues/15, but will fix in the Fedora one. > I would also prefer COPY (since ADD may have side effects). Ack. > > https://hhorak.fedorapeople.org/toolchain-docker/contrib/etc/scl_enable > > This seems redundant. Yes, this is not relevant in Fedora. > I would also like to see some documentation with better examples: how would > I use the container to compile my code? Good question, we should have it written better in the usage and provide some nice README.md, which is now missing entirely. Will work on it with Marek (original author of https://github.com/sclorg/devtoolset-container/tree/master/4-toolchain)
I believe I've fixed all issues mentioned above, new sources are still on the same place: Dockerfile URL: https://hhorak.fedorapeople.org/toolchain-docker/Dockerfile Other files URL: https://hhorak.fedorapeople.org/toolchain-docker/
One last nit (not blocking the transition): the readme is not being added into the image. Please make this change in dist-git. Otherwise I'm fine with the image, well done!
Also: $ docker run tt/maria /usr/bin/container-entrypoint: line 5: /usr/bin/usage: Permission denied You would run into it anyway. It doesn't have "+x".
Package request has been approved: https://admin.stg.fedoraproject.org/pkgdb/package/modules/toolchain
Package request has been approved: https://admin.stg.fedoraproject.org/pkgdb/package/modules/postfix
Package request has been approved: https://admin.stg.fedoraproject.org/pkgdb/package/docker/postfix
(In reply to Tomas Tomecek from comment #4) > One last nit (not blocking the transition): the readme is not being added > into the image. Please make this change in dist-git. Sure, will do > $ docker run tt/maria > /usr/bin/container-entrypoint: line 5: /usr/bin/usage: Permission denied I thought I fixed it already, but probably did not upload to the fedorapeople.org. The test should also catch this. Thanks Tomas!!
Package request has been denied with the reason: Please request in rpms namespace, not docker.
This is a container review, I believe docker namespace is correct.
Following https://fedoraproject.org/wiki/Container:Review_Process
Right you are, please resubmit.
Ok, done.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/toolchain
Since you already built the image, can we close this?
Yes, we can. Thanks for reminding.