Bug 1421605 - Container Review Request: nginx - Platform for running nginx or building nginx-based application
Summary: Container Review Request: nginx - Platform for running nginx or building ngin...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora Container Images
Classification: Fedora
Component: Container Review
Version: 26
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pavel Zhukov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1420947 (view as bug list)
Depends On:
Blocks: 1436796
TreeView+ depends on / blocked
 
Reported: 2017-02-13 09:00 UTC by Honza Horak
Modified: 2018-03-26 11:00 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-26 11:00:52 UTC
Type: ---
Embargoed:
pzhukov: fedora-review+


Attachments (Terms of Use)

Description Honza Horak 2017-02-13 09:00:51 UTC
Dockerfile URL: https://hhorak.fedorapeople.org/nginx-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/nginx-docker/

Description: This container image provides a platform for running nginx or building nginx-based application. Nginx is a web server and a reverse proxy server for HTTP, SMTP, POP3 and IMAP protocols, with a strong focus on high concurrency, performance and low memory usage.

Fedora Account System Username: hhorak

Comment 1 Mike Ruckman 2017-02-22 16:29:08 UTC
*** Bug 1420947 has been marked as a duplicate of this bug. ***

Comment 2 Pavel Zhukov 2017-03-28 19:13:53 UTC
I'll review it.

Comment 3 Pavel Zhukov 2017-04-01 20:46:23 UTC
Help files are missed.
Required labels are missed: https://fedoraproject.org/wiki/Container:Guidelines#LABELS

Comment 4 Honza Horak 2017-04-18 10:04:30 UTC
A help file and label added:

Dockerfile URL: https://hhorak.fedorapeople.org/nginx-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/nginx-docker/

Comment 5 Pavel Zhukov 2017-05-15 06:54:36 UTC
Sorry for the delay.
Summary is missed still. 
https://fedoraproject.org/wiki/Container:Guidelines#LABELS

Comment 6 Honza Horak 2017-05-24 07:34:33 UTC
Should be fixed now, thanks!

Comment 7 Pavel Zhukov 2017-05-24 11:19:22 UTC
bin/usage contains this:

DISTRO=`cat /etc/*-release | grep ^ID= | grep -Po '".*?"' | tr -d '"'`
NAMESPACE=centos
[[ $DISTRO =~ rhel* ]] && NAMESPACE=rhscl

Is it relevant to fedora anyhow?

Comment 8 Honza Horak 2017-05-24 14:30:48 UTC
It's not, I've removed it.

Comment 9 Pavel Zhukov 2017-05-30 15:32:56 UTC
Looks good for me.

Comment 10 Pavel Zhukov 2017-07-31 08:07:30 UTC
Any progress?

Comment 11 Honza Horak 2017-08-04 06:25:59 UTC
I've just tried to request the repo via the new tool fedrepo-req, but it does not work yet for containers obviously:

$> fedrepo-req -n container nginx -t 1421605
Error: The Bugzilla ticket provided is not the proper type

I've reported it as https://pagure.io/fedrepo_req/issue/29

Comment 12 Honza Horak 2017-08-20 21:27:58 UTC
Pavel, the fedrepo-req seems to be fixed, but it complains that "Error: The Bugzilla ticket's review was approved over 60 days ago".. So, please, re-approve this request.

Comment 13 Honza Horak 2017-08-21 09:51:01 UTC
Thanks Pavel, the ticket is finally created.

Comment 14 Gwyn Ciesla 2017-08-22 13:29:21 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/nginx

Comment 15 Dusty Mabe 2017-11-17 15:07:05 UTC
the git repo was created but no image ever put into fedora. can we get that to happen?


Note You need to log in before you can comment on or make changes to this bug.