Description of problem: When running ovirt vacuum only sql commands are written to command line. Either write them with proper descrription or dont write anything. Non educated user about sql does not know what these means. Version-Release number of selected component (if applicable): rhevm-4.1.1-0.1.el7.noarch How reproducible: 100% Steps to Reproduce: 1. [root@ls-engine1 ~]# engine-vacuum VACUUM; 1. [root@ls-engine1 ~]# engine-vacuum -f VACUUM (FULL); Actual results: 1. VACUUM; 2. VACUUM (FULL); Expected results: 1. Running vacuum on database, sql: VACUUM 2. Running full vacuum on database, sql: VACUUM (FULL)
Any updates on this?
You have a -v flag for verbosity, which is exactly what needed. ``` engine-vacuum -v ... CPU 0.00s/0.00u sec elapsed 0.00 sec. INFO: "pg_toast_1016191": found 0 removable, 0 nonremovable row versions in 0 out of 0 pages DETAIL: 0 dead row versions cannot be removed yet. There were 0 unused item pointers. Skipped 0 pages due to buffer pins. 0 pages are entirely empty. CPU 0.00s/0.00u sec elapsed 0.00 sec. VACUUM (VERBOSE); ```
(In reply to Roy Golan from comment #2) > You have a -v flag for verbosity, which is exactly what needed. > > ``` > engine-vacuum -v > ... > CPU 0.00s/0.00u sec elapsed 0.00 sec. > INFO: "pg_toast_1016191": found 0 removable, 0 nonremovable row versions in > 0 out of 0 pages > DETAIL: 0 dead row versions cannot be removed yet. > There were 0 unused item pointers. > Skipped 0 pages due to buffer pins. > 0 pages are entirely empty. > CPU 0.00s/0.00u sec elapsed 0.00 sec. > VACUUM (VERBOSE); > ``` So is it going to 4.1.2? Is the bug fixed? What's the status?
As discussed in the past with Roy, we should suppress output if verbose is not specified (displaying "VACUUM;" or "VACUUM (FULL);"). If verbose is specified then we will show full output of the command as mentioned in Comment 2. @Roy will you prepare the fix or should I assign it to someone else?
verified in ovirt-engine-4.1.2.1-0.1.el7.noarch