Dockerfile URL: https://github.com/projectatomic/atomic-system-containers/blob/master/etcd/Dockerfile
etcd is a key-value store for shared configuration and service discovery. This package is intended to be ran as a system container.
More information on system containers here: http://www.projectatomic.io/blog/2016/09/intro-to-system-containers/
A quick guide: https://github.com/yuqi-zhang/atomic-system-containers-quickstart
Fedora Account System Username: yzhang
Same as flannel, please pin base image to latest stable tag:
> FROM fedora
> RUN dnf -y install etcd hostname && \
This also holds for flannel: please install packages without documentation as described in "Container best practices":
It would be also helpful to indicate which ports are meant to be exposed (you write that the container is meant to run as system container, but one can still run it within docker, right?)
> # git clone https://github.com/aveshagarwal/etcd-container
`git clone` in readme seems to be out of date.
Same for documentation, it would be really helpful for users to have something. But I guess since there are no formal guidelines for this, let's postpone (same for flannel), there is readme in the repo, should be enough for now.
Thanks for the review! I've made the fixes to etcd and flannel here: https://github.com/projectatomic/atomic-system-containers/pull/32
I don't want to nitpick, but it's `maintainer`, with lower-case 'm'. Also, please use EXPOSE instruction inside etcd Dockerfile to indicate, which ports are meant to be exposed.
These are really minor, will grant review+ once done.
Since you are not sponsored yet, have you tried to get a sponsor?
Since are not set as maintainer inside Dockerfile, is Giuseppe okay with this? Will both of you maintain the image in Fedora?
Fixed in: https://github.com/projectatomic/atomic-system-containers/commit/759decde35f539e743689020e251f9a8fcc5eb07
I have talked to Adam Miller about sponsoring. As for maintainer, technically projectatomic as an organization will be the maintainer. I've talked to Giuseppe and he's ok with being the listed maintainer for now.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/etcd