Bug 1422378 - Warning appear if build with ImageStreamImage
Summary: Warning appear if build with ImageStreamImage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Build
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Gabe Montero
QA Contact: Wenjing Zheng
URL:
Whiteboard:
: 1502017 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-15 07:19 UTC by Wenjing Zheng
Modified: 2020-12-14 08:10 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: The new-app circular dependency code did not account for BuildConfig sources pointing to the ImageStreamImage type Consequence: An unnecessary warning was logged about not being able to follow the reference type ImageStreamImage Fix: Enhance the new-app circular dependency code to account for the ImageStreamImage type Result: The unnecessary warning no longer appears
Clone Of:
Environment:
Last Closed: 2017-08-10 05:18:47 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1716 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.6 RPM Release Advisory 2017-08-10 09:02:50 UTC

Description Wenjing Zheng 2017-02-15 07:19:28 UTC
Description of problem:
Below warning appears when build with ImageStreamImage (build can be successfully ):
W0215 14:51:29.476413    1129 newapp.go:887] Unable to check for circular build input: Unable to follow reference type: "ImageStreamImage"

Version-Release number of selected component (if applicable):
openshift v3.5.0.20+87266c6
kubernetes v1.5.2+43a9be4
etcd 3.1.0

How reproducible:
always

Steps to Reproduce:
1. oc import-image ruby --from=docker.io/openshift/ruby-22-centos7 --confirm=true
2. oc get is ruby -o yaml
3. Edit to use ImageStreamImage to build:  
  strategy:
    sourceStrategy:
      env:
      - name: EXAMPLE
        value: sample-app
      from:
        kind: ImageStreamImage
        name: ruby@sha256:5dc0856fea9551e102815863cceeabd3aee862ec4ad5f2625eb51564924f0360
    type: Source


Actual results:
Warning appears although build completes:W0215 14:51:29.476413    1129 newapp.go:887] Unable to check for circular build input: Unable to follow reference type: "ImageStreamImage"

Expected results:
Should be no such error

Additional info:

Comment 1 Cesar Wong 2017-02-15 14:07:51 UTC
Can you please include the exact command you executed to get that error?
I ran:
oc start-build bc/ruby-test 
(After modifying the bc to point to an ImageStreamImage)

I was not able to reproduce.

Comment 2 Cesar Wong 2017-02-15 14:21:33 UTC
Cancelling needinfo ... was able to reproduce by exporting the bc with the imagestreamimage reference as a template, then calling new-app on that template.

Comment 3 Cesar Wong 2017-02-15 14:24:20 UTC
Gabe, sending your way since this is your code. We shouldn't warn if there's nothing to check.

Comment 4 Gabe Montero 2017-03-03 21:47:06 UTC
PR https://github.com/openshift/origin/pull/13233 is carrying the fix for this

Comment 5 openshift-github-bot 2017-03-04 08:02:12 UTC
Commits pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/5b464bfd8b4542212be93c688a40a744dbbb686f
Enhance new-app circular test to handle ImageStreamImage refs

bug 1422378
https://bugzilla.redhat.com/show_bug.cgi?id=1422378

https://github.com/openshift/origin/commit/a5cb4d68cd2fa957cf4a7cea2f13c7db10a58855
Merge pull request #13233 from gabemontero/bug1422378

Merged by openshift-bot

Comment 6 Gabe Montero 2017-03-04 14:01:00 UTC
Per OCP process moving to MODIFIED

Comment 7 Troy Dawson 2017-03-06 19:01:14 UTC
Is this for 3.5 or 3.6?
Everything in the bug says for 3.5, but the pull request is for origin/master which is 3.6.

If it is for 3.5, you need to do a pull request for origin/release-1.5

Comment 8 Gabe Montero 2017-03-06 19:12:59 UTC
The bug was found during 3.5 testing, but given the low priority/severity, we are proposing only fixing it in 3.6.

Comment 9 Gabe Montero 2017-03-06 19:13:56 UTC
Apologies for not selecting the target release earlier.

Comment 10 Troy Dawson 2017-04-11 20:58:13 UTC
This has been merged into ocp and is in OCP v3.6.27 or newer.

Comment 12 Wenjing Zheng 2017-04-12 09:11:31 UTC
Verified with below version, no such error now:
openshift v3.6.27
kubernetes v1.5.2+43a9be4
etcd 3.1.0

Comment 14 errata-xmlrpc 2017-08-10 05:18:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716

Comment 15 Gabe Montero 2017-10-19 15:32:28 UTC
*** Bug 1502017 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.