Spec URL: https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools-2.11.1-1.fc26.src.rpm Description: A set of tools and utilities for the DAHDI drivers Fedora Account System Username: jsmith I'm attempting to un-retire the dahdi-tools package, but it needs to be re-reviewed.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: coreutils gcc sed make findutils See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file astribank_license.c is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== C/C++: [?]: Package does not contain kernel modules. [?]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. [?]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [?]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dahdi- tools-libs , dahdi-tools-devel , dahdi-tools-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [?]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define tools_version 2.11.1, %define linux_version 2.11.1 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dahdi-tools-2.11.1-1.fc23.x86_64.rpm dahdi-tools-libs-2.11.1-1.fc23.x86_64.rpm dahdi-tools-devel-2.11.1-1.fc23.x86_64.rpm dahdi-tools-debuginfo-2.11.1-1.fc23.x86_64.rpm dahdi-tools-2.11.1-1.fc23.src.rpm dahdi-tools.x86_64: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace dahdi-tools.x86_64: E: incorrect-fsf-address /usr/share/dahdi/xpp_fxloader dahdi-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/dahdi-tools/LICENSE dahdi-tools.x86_64: E: incorrect-fsf-address /usr/share/dahdi/waitfor_xpds dahdi-tools.x86_64: W: no-manual-page-for-binary dahdi_speed dahdi-tools-libs.x86_64: W: no-documentation dahdi-tools-libs.x86_64: E: incorrect-fsf-address /usr/share/licenses/dahdi-tools-libs/LICENSE dahdi-tools-devel.x86_64: W: only-non-binary-in-usr-lib dahdi-tools-devel.x86_64: W: no-documentation dahdi-tools-devel.x86_64: E: incorrect-fsf-address /usr/share/licenses/dahdi-tools-devel/LICENSE dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/pic_loader.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk-xusb.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/xusb.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xusb_common.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_base.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/debug.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/mpptalk.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_sync.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/parse_span_specs.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/pic_loader.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/proto.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/debug.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/mpptalk.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/proto_sync.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/debug.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/echo_loader.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_base.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/hexfile.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_tool.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/parse_span_specs.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_hexload.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/echo_loader.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_license.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_send.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/hexfile.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_allow.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xusb_libusbx.c dahdi-tools.src: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace dahdi-tools.src:78: W: macro-in-comment %{__perl} dahdi-tools.src:81: W: macro-in-comment %patch1 dahdi-tools.src:82: W: macro-in-comment %patch2 dahdi-tools.src:105: W: macro-in-comment %{buildroot} dahdi-tools.src:105: W: macro-in-comment %{_initrddir} dahdi-tools.src:110: W: macro-in-comment %{_datadir} dahdi-tools.src:110: W: macro-in-comment %{buildroot} dahdi-tools.src:110: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:141: W: macro-in-comment %config dahdi-tools.src:141: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:142: W: macro-in-comment %config dahdi-tools.src:142: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:146: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:147: W: macro-in-comment %config dahdi-tools.src:147: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:148: W: macro-in-comment %config dahdi-tools.src:148: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:149: W: macro-in-comment %config dahdi-tools.src:149: W: macro-in-comment %{_sysconfdir} dahdi-tools.src:152: W: macro-in-comment %{_initrddir} dahdi-tools.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 29) dahdi-tools.src: W: patch-not-applied Patch1: mpptalk-oper-fix.patch 5 packages and 0 specfiles checked; 32 errors, 30 warnings. Rpmlint (debuginfo) ------------------- Checking: dahdi-tools-debuginfo-2.11.1-1.fc23.x86_64.rpm dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_allow.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/hexfile.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/debug.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/debug.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/xusb.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/proto_sync.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk-xusb.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/proto.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xusb_libusbx.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_base.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/hexfile.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/pic_loader.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_send.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xusb_common.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/parse_span_specs.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/echo_loader.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/debug.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_sync.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_hexload.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/mpptalk.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_tool.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/echo_loader.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/mpptalk.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_base.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/parse_span_specs.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_license.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/pic_loader.c 1 packages and 0 specfiles checked; 27 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory dahdi-tools.x86_64: E: incorrect-fsf-address /usr/share/dahdi/waitfor_xpds dahdi-tools.x86_64: E: incorrect-fsf-address /usr/share/dahdi/xpp_fxloader dahdi-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/dahdi-tools/LICENSE dahdi-tools.x86_64: W: no-manual-page-for-binary dahdi_speed dahdi-tools-devel.x86_64: W: only-non-binary-in-usr-lib dahdi-tools-devel.x86_64: W: no-documentation dahdi-tools-devel.x86_64: E: incorrect-fsf-address /usr/share/licenses/dahdi-tools-devel/LICENSE dahdi-tools-libs.x86_64: W: no-documentation dahdi-tools-libs.x86_64: E: incorrect-fsf-address /usr/share/licenses/dahdi-tools-libs/LICENSE dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/pic_loader.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/pic_loader.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/parse_span_specs.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/echo_loader.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/echo_loader.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xusb_libusbx.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/debug.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_tool.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/hexfile.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/proto_sync.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_base.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_hexload.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_sync.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_send.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/mpptalk.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xusb_common.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_license.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk-xusb.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/xtalk_base.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/parse_span_specs.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/proto.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/mpptalk.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/xusb.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/hexfile.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/include/xtalk/debug.h dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/astribank_allow.c dahdi-tools-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/dahdi-tools-2.11.1/xpp/xtalk/debug.h 4 packages and 0 specfiles checked; 32 errors, 4 warnings. Requires -------- dahdi-tools (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl /usr/sbin/groupadd /usr/sbin/useradd config(dahdi-tools) dahdi-tools-libs(x86-64) libc.so.6()(64bit) libm.so.6()(64bit) libnewt.so.0.52()(64bit) libnewt.so.0.52(NEWT_0.52)(64bit) libpthread.so.0()(64bit) libtonezone.so.2()(64bit) libusb-1.0.so.0()(64bit) perl(:MODULE_COMPAT_5.22.2) perl(Dahdi) perl(Dahdi::Chans) perl(Dahdi::Config::Gen) perl(Dahdi::Config::Params) perl(Dahdi::Hardware) perl(Dahdi::Span) perl(Dahdi::Utils) perl(Dahdi::Xpp) perl(Dahdi::Xpp::Line) perl(Dahdi::Xpp::Mpp) perl(Dahdi::Xpp::Xbus) perl(Dahdi::Xpp::Xpd) perl(Exporter) perl(File::Basename) perl(Getopt::Long) perl(Getopt::Std) perl(Socket) perl(strict) rtld(GNU_HASH) systemd dahdi-tools-devel (rpmlib, GLIBC filtered): dahdi-tools-libs(x86-64) libtonezone.so.2()(64bit) dahdi-tools-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) dahdi-tools-debuginfo (rpmlib, GLIBC filtered): Provides -------- dahdi-tools: config(dahdi-tools) dahdi-tools dahdi-tools(x86-64) perl(Dahdi) perl(Dahdi::Chans) perl(Dahdi::Config::Gen) perl(Dahdi::Config::Gen::Assignedspans) perl(Dahdi::Config::Gen::Chandahdi) perl(Dahdi::Config::Gen::Freepbxdb) perl(Dahdi::Config::Gen::Modules) perl(Dahdi::Config::Gen::Spantypes) perl(Dahdi::Config::Gen::System) perl(Dahdi::Config::Gen::Unicall) perl(Dahdi::Config::Gen::Users) perl(Dahdi::Config::Gen::Xpporder) perl(Dahdi::Config::Params) perl(Dahdi::Hardware) perl(Dahdi::Hardware::PCI) perl(Dahdi::Hardware::USB) perl(Dahdi::Span) perl(Dahdi::Utils) perl(Dahdi::Xpp) perl(Dahdi::Xpp::Line) perl(Dahdi::Xpp::Mpp) perl(Dahdi::Xpp::Xbus) perl(Dahdi::Xpp::Xpd) dahdi-tools-devel: dahdi-tools-devel dahdi-tools-devel(x86-64) dahdi-tools-libs: dahdi-tools-libs dahdi-tools-libs(x86-64) libtonezone.so.2()(64bit) dahdi-tools-debuginfo: dahdi-tools-debuginfo dahdi-tools-debuginfo(x86-64) Source checksums ---------------- http://downloads.asterisk.org/pub/telephony/dahdi-linux/releases/dahdi-linux-2.11.1.tar.gz : CHECKSUM(SHA256) this package : f59f382365118205e77d2874f1c0e1546e936247bcc45f07a43bc21778bee9df CHECKSUM(SHA256) upstream package : f59f382365118205e77d2874f1c0e1546e936247bcc45f07a43bc21778bee9df http://downloads.asterisk.org/pub/telephony/dahdi-linux/releases/dahdi-linux-2.11.1.tar.gz.asc : CHECKSUM(SHA256) this package : 0022ac09e9cba17b5ac9421292824c0384dcb70539272da2415f6abf664d1f1a CHECKSUM(SHA256) upstream package : 0022ac09e9cba17b5ac9421292824c0384dcb70539272da2415f6abf664d1f1a http://downloads.asterisk.org/pub/telephony/dahdi-tools/releases/dahdi-tools-2.11.1.tar.gz : CHECKSUM(SHA256) this package : 53ffeb333f3e44b0c88e5b17475cdbf87d3f652eb81a6422de76250c061e2909 CHECKSUM(SHA256) upstream package : 53ffeb333f3e44b0c88e5b17475cdbf87d3f652eb81a6422de76250c061e2909 http://downloads.asterisk.org/pub/telephony/dahdi-tools/releases/dahdi-tools-2.11.1.tar.gz.asc : CHECKSUM(SHA256) this package : 1f194e68c460c80c8e6fe4525749e2f45e93771a87d8d8955a4e73a8ed903e99 CHECKSUM(SHA256) upstream package : 1f194e68c460c80c8e6fe4525749e2f45e93771a87d8d8955a4e73a8ed903e99 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1422683 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Shell-api, C/C++, Perl Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
What do we need to do to get this sorted? ideally we need to get this back in for F26 so we can update asterisk... It looks like there are three issues in the review output: * Build dependencies * License breakdown * Need to require udev (or own udev rules directory) * Rename requires correct obsoletes etc * Use of %define I don't understand the build dependency issue - the linked page doesn't seem to be relevant and things like gcc are actually supposed to be required now. Equally this isn't a rename so that point doesn't seem to be relevant? Fixing the %defines is presumably easy. So if the license breakdown the main issue? I don't recall seeing that requirement before - are we really expected to write a big list of which source files are under which license and embed it in the spec?
Please specify what exactly the issue ? I can help with some systemd or packing issues.
I checked https://jsmith.fedorapeople.org/Packaging/dahdi-tools/ rpm and systemd service file and is it not easy move init script to /usr/bin/dahdictl and in systemd ExecStart=/usr/bin/dahdictl start same for stop and reload ?
Is possible increase priority on this ticket ?
Please calm down. No, you can't increase the priority - well you can but it won't do any good because we're all volunteers so there's no manager sitting down prioritising bugs and telling people what to do. I'm sure when Jared has time he will get back to this.
My most sincere apologies for the latency on this issue... I've been wholly consumed with work (12+ hours per day) and some pressing personal/family issues that have consumed the "free" time I typically use for contributing to projects like Asterisk and Fedora. (In reply to Leif Madsen from comment #1) > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: coreutils gcc sed make findutils > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Fixed in latest version listed below. > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file astribank_license.c is not marked as %license > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text This is a false positive -- astribank_license.c is not an actual license file. It looks like Leif dropped himself off from doing the review -- would anyone else like to pick it up and finish the review so that we can un-retire this package? Spec URL: https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools-2.11.1-2.fc27.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file astribank_license.c is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/dahdi-tools See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2 or later)", "*No copyright* GPL (v2)", "Unknown or generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "*No copyright* CC0 (v8)", "Perl", "*No copyright* LGPL (v2.1)", "LGPL (v2.1)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2) (with incorrect FSF address)", "GPL (v2)". 213 files have unknown license. Detailed output of licensecheck in /home/tom/1422683-dahdi- tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [!]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dahdi- tools-libs , dahdi-tools-devel , dahdi-tools-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dahdi-tools-2.11.1-2.fc27.x86_64.rpm dahdi-tools-libs-2.11.1-2.fc27.x86_64.rpm dahdi-tools-devel-2.11.1-2.fc27.x86_64.rpm dahdi-tools-debuginfo-2.11.1-2.fc27.x86_64.rpm dahdi-tools-2.11.1-2.fc27.src.rpm dahdi-tools.x86_64: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: no-manual-page-for-binary dahdi_speed dahdi-tools-libs.x86_64: W: no-documentation dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools-devel.x86_64: W: only-non-binary-in-usr-lib dahdi-tools-devel.x86_64: W: no-documentation dahdi-tools.src: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace 5 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: dahdi-tools-debuginfo-2.11.1-2.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory dahdi-tools.x86_64: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: no-manual-page-for-binary dahdi_speed dahdi-tools-devel.x86_64: W: only-non-binary-in-usr-lib dahdi-tools-devel.x86_64: W: no-documentation dahdi-tools-libs.x86_64: W: no-documentation dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Requires -------- dahdi-tools (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl /usr/sbin/groupadd /usr/sbin/useradd config(dahdi-tools) dahdi-tools-libs(x86-64) libc.so.6()(64bit) libm.so.6()(64bit) libnewt.so.0.52()(64bit) libnewt.so.0.52(NEWT_0.52)(64bit) libpthread.so.0()(64bit) libtonezone.so.2()(64bit) libusb-1.0.so.0()(64bit) perl(:MODULE_COMPAT_5.24.1) rtld(GNU_HASH) systemd dahdi-tools-devel (rpmlib, GLIBC filtered): dahdi-tools-libs(x86-64) libtonezone.so.2()(64bit) dahdi-tools-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) dahdi-tools-debuginfo (rpmlib, GLIBC filtered): Provides -------- dahdi-tools: config(dahdi-tools) dahdi-tools dahdi-tools(x86-64) dahdi-tools-devel: dahdi-tools-devel dahdi-tools-devel(x86-64) dahdi-tools-libs: dahdi-tools-libs dahdi-tools-libs(x86-64) libtonezone.so.2()(64bit) dahdi-tools-debuginfo: dahdi-tools-debuginfo dahdi-tools-debuginfo(x86-64) Source checksums ---------------- http://downloads.asterisk.org/pub/telephony/dahdi-linux/releases/dahdi-linux-2.11.1.tar.gz : CHECKSUM(SHA256) this package : f59f382365118205e77d2874f1c0e1546e936247bcc45f07a43bc21778bee9df CHECKSUM(SHA256) upstream package : f59f382365118205e77d2874f1c0e1546e936247bcc45f07a43bc21778bee9df http://downloads.asterisk.org/pub/telephony/dahdi-linux/releases/dahdi-linux-2.11.1.tar.gz.asc : CHECKSUM(SHA256) this package : 0022ac09e9cba17b5ac9421292824c0384dcb70539272da2415f6abf664d1f1a CHECKSUM(SHA256) upstream package : 0022ac09e9cba17b5ac9421292824c0384dcb70539272da2415f6abf664d1f1a http://downloads.asterisk.org/pub/telephony/dahdi-tools/releases/dahdi-tools-2.11.1.tar.gz : CHECKSUM(SHA256) this package : 53ffeb333f3e44b0c88e5b17475cdbf87d3f652eb81a6422de76250c061e2909 CHECKSUM(SHA256) upstream package : 53ffeb333f3e44b0c88e5b17475cdbf87d3f652eb81a6422de76250c061e2909 http://downloads.asterisk.org/pub/telephony/dahdi-tools/releases/dahdi-tools-2.11.1.tar.gz.asc : CHECKSUM(SHA256) this package : 1f194e68c460c80c8e6fe4525749e2f45e93771a87d8d8955a4e73a8ed903e99 CHECKSUM(SHA256) upstream package : 1f194e68c460c80c8e6fe4525749e2f45e93771a87d8d8955a4e73a8ed903e99 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1422683 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Perl Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Do we need a systemd-udev require? or do we just assume that is present? Per https://fedoraproject.org/wiki/Packaging:Perl I believe we need BRs on perl-generators and possibly on perl? The systemd unit is obviously horrendous... I assume it's mostly just copying the logic from the old init script but I wonder if it wouldn't be better to put all that in a script where it would be more readable. I mean I think half of it likely shouldn't be there at all really but that might be too big a change for a legacy package like this.
I've gone ahead and added a Requires for systemd-udev, just to be explicit. I've added a BuildRequires on perl-generators as well. As for the systemd unit file -- yes, it's horrendous. I'm simply using the systemd unit file that one of the Digium engineers provided -- even he admits it was a quick and dirty rewrite of the init script in systemd form. I haven't really taken any time to try to improve it, but I'm open to suggestions (or patches) on how to make it better. Spec URL: https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools-2.11.1-3.fc27.src.rpm
If that's come from upstream then I guess we should go with it - presumably it will be included in a future release anyway. So on that basis I think we can approve this.
dahdi-tools-2.11.1-6.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a7778ba64a
dahdi-tools-2.11.1-6.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a7778ba64a
dahdi-tools-2.11.1-6.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.