Bug 1422689 - Review Request: python-openqa_client - Python client library for openQA API
Summary: Review Request: python-openqa_client - Python client library for openQA API
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-15 22:02 UTC by Adam Williamson
Modified: 2017-02-16 16:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-16 16:19:04 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Adam Williamson 2017-02-15 22:02:32 UTC
Spec URL: https://www.happyassassin.net/reviews/python-openqa_client/python-openqa_client.spec
SRPM URL: https://www.happyassassin.net/reviews/python-openqa_client/python-openqa_client-1.3.0-1.fc26.src.rpm
Description: The openqa_client Python library provides convenient access to the openQA web API, using the requests HTTP request library.
Fedora Account System Username: adamwill

Comment 1 Neal Gompa 2017-02-16 00:07:21 UTC
Taking this review.

Comment 2 Neal Gompa 2017-02-16 00:36:59 UTC
Review notes:

+ Package is named correctly
+ Package has license noted correctly and license file is installed in all subpackages
+ Subpackages are set up according to Python packaging guidelines
+ No issues from rpmlint or fedora-review
- Empty %check section (at least you know, so not dinging you about it!)
! Unnecessary "rm -rf %{buildroot}" in %install (this isn't targeting EL5...)

It looks good to me. Just drop the unnecessary command in %install mentioned above on import.

PACKAGE APPROVED.

Comment 3 Adam Williamson 2017-02-16 00:45:21 UTC
Thanks.

Comment 4 Gwyn Ciesla 2017-02-16 13:31:38 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-openqa_client

Comment 5 Adam Williamson 2017-02-16 16:19:04 UTC
https://koji.fedoraproject.org/koji/buildinfo?buildID=859718

Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.