Bug 1422888 - [downstream clone - 4.0.7] Incorrect links in REST API for /imagetransfers
Summary: [downstream clone - 4.0.7] Incorrect links in REST API for /imagetransfers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ovirt-4.0.7
: ---
Assignee: Liron Aravot
QA Contact: Gonza
URL:
Whiteboard:
Depends On: 1401873
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-16 13:17 UTC by rhev-integ
Modified: 2017-03-16 15:34 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1401873
Environment:
Last Closed: 2017-03-16 15:34:09 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0542 0 normal SHIPPED_LIVE Red Hat Virtualization Manager 4.0.7 2017-03-16 19:25:04 UTC
oVirt gerrit 69723 0 master ABANDONED ImageTransfer - removing image link 2017-02-16 13:18:12 UTC
oVirt gerrit 69797 0 master MERGED ImageTransfer - removing image link 2017-02-16 13:18:12 UTC
oVirt gerrit 70539 0 ovirt-engine-4.1 MERGED ImageTransfer - removing image link 2017-02-16 13:18:12 UTC
oVirt gerrit 71901 0 ovirt-engine-4.0 MERGED ImageTransfer - removing image link 2017-02-16 13:18:12 UTC

Description rhev-integ 2017-02-16 13:17:33 UTC
+++ This bug is an upstream to downstream clone. The original bug is: +++
+++   bug 1401873 +++
======================================================================

curl https://engine/ovirt-engine/api/imagetransfers/

<image_transfers>
  <image_transfer href="/ovirt-engine/api/imagetransfers/71dff49f-f743-4395-927d-0ee7cf243a66" id="71dff49f-f743-4395-927d-0ee7cf243a66">
    ...
    <image href="/ovirt-engine/api/null/8603e3ed-6d90-4a36-93fa-8bfacef22fea" id="8603e3ed-6d90-4a36-93fa-8bfacef22fea"/>
    ...
  </image_transfer>
</image_transfers>

There is "null" in Image link:

  <image href="/ovirt-engine/api/null/8603e3ed-6d90-4a36-93fa-8bfacef22fea" id="8603e3ed-6d90-4a36-93fa-8bfacef22fea"/>

Also, shouldn't this be disk, instead of image??

(Originally by Ondra Machacek)

Comment 1 rhev-integ 2017-02-16 13:17:42 UTC
Thanks Ondra,
The cause for the bug here is that we use "image" instead of "disk" in the api- currently when uploading we pass the disk id but as an image which is confusing.

For 4.0 I'm going to remove the link to the image which, on 4.1/4.2 we'll change the api (with backward compatibility) to accept a disk element and we'll have proper link.
Looking forward, when we'll add support to upload to a specific disk snapshot (=image) we'll let the user specify a destination snapshot id within the disk as well (if not specified the 'active' snapshot will be used).

Thanks,
Liron

(Originally by Liron Aravot)

Comment 3 rhev-integ 2017-02-16 13:17:49 UTC
Adding, the term "Image" is currently used in our api for glance images import (contains the details of the glance image) aside from the image transfer usage.

(Originally by Liron Aravot)

Comment 4 rhev-integ 2017-02-16 13:17:56 UTC
4.0.6 has been the last oVirt 4.0 release, please re-target this bug.

(Originally by Sandro Bonazzola)

Comment 7 Gonza 2017-03-02 12:35:09 UTC
Verified with:
rhevm-4.0.7.3-0.1.el7ev.noarch

href removed:
<image_transfers>
  <image_transfer href="/ovirt-engine/api/imagetransfers/9a7e98ac-b509-4bf2-8ba2-5b08e426e064" id="9a7e98ac-b509-4bf2-8ba2-5b08e426e064">
...
    <image id="7172c76a-4ef3-443d-89e9-ed4c2b848ecd"/>
  </image_transfer>
</image_transfers>

Comment 9 errata-xmlrpc 2017-03-16 15:34:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0542.html


Note You need to log in before you can comment on or make changes to this bug.