Spec URL: https://fedorapeople.org/~jwrdegoede/akmods.spec SRPM URL: https://fedorapeople.org/~jwrdegoede/akmods-0.5.6-3.fc25.src.rpm Description: Akmods startup script will rebuild akmod packages during system boot while its background daemon will build them for kernels right after they were installed. Fedora Account System Username: jwrdegoede rpmlint output: akmods.noarch: W: non-standard-uid /var/cache/akmods akmods akmods.noarch: W: non-standard-gid /var/cache/akmods akmods akmods.noarch: W: no-manual-page-for-binary akmods-shutdown akmods.noarch: W: empty-%postun rpmbuild/SPECS/akmods.spec:75: E: hardcoded-library-path in %{_prefix}/lib/systemd/system-preset rpmbuild/SPECS/akmods.spec:85: E: hardcoded-library-path in %{_prefix}/lib/systemd/system-preset/ rpmbuild/SPECS/akmods.spec:129: E: hardcoded-library-path in %{_prefix}/lib/systemd/system-preset/95-akmods.preset 1 packages and 1 specfiles checked; 3 errors, 4 warnings. These are all expected given the nature of the package and can all be ignored.
Taking this review.
(In reply to Hans de Goede from comment #0) > Spec URL: https://fedorapeople.org/~jwrdegoede/akmods.spec > SRPM URL: https://fedorapeople.org/~jwrdegoede/akmods-0.5.6-3.fc25.src.rpm > Description: > Akmods startup script will rebuild akmod packages during system > boot while its background daemon will build them for kernels right > after they were installed. > > Fedora Account System Username: jwrdegoede > > rpmlint output: > > akmods.noarch: W: non-standard-uid /var/cache/akmods akmods > akmods.noarch: W: non-standard-gid /var/cache/akmods akmods > akmods.noarch: W: no-manual-page-for-binary akmods-shutdown > akmods.noarch: W: empty-%postun > rpmbuild/SPECS/akmods.spec:75: E: hardcoded-library-path in > %{_prefix}/lib/systemd/system-preset > rpmbuild/SPECS/akmods.spec:85: E: hardcoded-library-path in > %{_prefix}/lib/systemd/system-preset/ > rpmbuild/SPECS/akmods.spec:129: E: hardcoded-library-path in > %{_prefix}/lib/systemd/system-preset/95-akmods.preset > 1 packages and 1 specfiles checked; 3 errors, 4 warnings. > > These are all expected given the nature of the package and can all be > ignored. Please replace %{_prefix}/lib/systemd/system-preset with %{_presetdir} $ rpm -E %{_presetdir} /usr/lib/systemd/system-preset
(In reply to leigh scott from comment #2) > Please replace %{_prefix}/lib/systemd/system-preset with %{_presetdir} Done: Spec URL: https://fedorapeople.org/~jwrdegoede/akmods.spec SRPM URL: https://fedorapeople.org/~jwrdegoede/akmods-0.5.6-4.fc25.src.rpm New rpmlint output: [hans@shalem ~]$ rpmlint rpmbuild/SRPMS/akmods-0.5.6-4.fc25.src.rpm rpmbuild/RPMS/noarch/akmods-0.5.6-4.fc25.noarch.rpm akmods.noarch: W: non-standard-uid /var/cache/akmods akmods akmods.noarch: W: non-standard-gid /var/cache/akmods akmods akmods.noarch: W: no-manual-page-for-binary akmods-shutdown akmods.noarch: W: empty-%postun 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Review notes: + Named correctly + Follows packaging guidelines on how it should be installed + systemd services are installed correctly + Provides/Requires look sane + Scriptlets look sane ! License file missing and isn't installed.
New version: * Mon Mar 6 2017 Hans de Goede <hdegoede> - 0.5.6-5 - Add LICENSE file (rhbz#1422918) Spec URL: https://fedorapeople.org/~jwrdegoede/akmods.spec SRPM URL: https://fedorapeople.org/~jwrdegoede/akmods-0.5.6-5.fc25.src.rpm
PACKAGE APPROVED.
PackageDB admin request done.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/akmods
akmods-0.5.6-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-427882437f
akmods-0.5.6-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-427882437f
akmods-0.5.6-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.