Bug 1422979 - tarball packaging issues -> pypi different data
Summary: tarball packaging issues -> pypi different data
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: Build
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.1.1
: 4.1.1
Assignee: Juan Hernández
QA Contact: Pavol Brilla
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-16 17:32 UTC by Sandro Bonazzola
Modified: 2017-04-21 09:38 UTC (History)
5 users (show)

Fixed In Version: python-ovirt-engine-sdk4-4.1.1-1.el7ev
Clone Of:
Environment:
Last Closed: 2017-04-21 09:38:49 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 72468 0 master MERGED Don't generate custom tarball 2017-02-17 09:18:50 UTC
oVirt gerrit 72487 0 sdk_4.1 MERGED Don't generate custom tarball 2017-02-17 09:28:49 UTC

Description Sandro Bonazzola 2017-02-16 17:32:36 UTC
Description of problem:
https://pypi.io/packages/source/o/ovirt-engine-sdk-python/ovirt-engine-sdk-python-4.1.0.tar.gz 

is missing examples which are instead packaged in 

http://resources.ovirt.org/pub/ovirt-4.1/src/python-ovirt-engine-sdk4/ovirt-engine-sdk-python-4.1.0.tar.gz

not sure if pypi archive is corrupted or why they differ.
In principle, the 2 tarball should have same checksum.

Comment 1 Juan Hernández 2017-02-16 17:41:34 UTC
Those are two different kinds or tarballs. The first is the source distribution, generated by 'setup.py sdist'. The second is a tarball generated by our automation scripts, not really useful. We should probably stop generate that second tarball using 'setup.py sdist' as well.

Is this causing a real problem?

Comment 2 Sandro Bonazzola 2017-02-17 14:13:52 UTC
(In reply to Juan Hernández from comment #1)
> Those are two different kinds or tarballs. The first is the source
> distribution, generated by 'setup.py sdist'. The second is a tarball
> generated by our automation scripts, not really useful. We should probably
> stop generate that second tarball using 'setup.py sdist' as well.
> 
> Is this causing a real problem?

Just seen it while building CentOS Virt SIG rpm. In CentOS Virt SIG rpm 4.0 I was using pypi tar.gz as source and I had the example directory shipped within the rpm.
In 4.1 pypi version the example directory is not shipped anymore so I noticed the issue.

Comment 3 Juan Hernández 2017-02-17 14:41:13 UTC
Strange, I think that the examples have never been included in the PyPI version. They should be now.

Comment 4 Pavol Brilla 2017-04-11 10:47:01 UTC
Check of package: 

https://pypi.io/packages/source/o/ovirt-engine-sdk-python/ovirt-engine-sdk-python-4.1.3.tar.gz 

contains examples directory.

But those 2 sources dont have same checksum

Source: https://pypi.io/packages/...
$ md5sum ovirt-engine-sdk-python-4.1.3.tar.gz 
20874fd9062072879e1786749f6be40f  ovirt-engine-sdk-python-4.1.3.tar.gz

Source: http://resources.ovirt.org/pub/...
$ md5sum ovirt-engine-sdk-python-4.1.3.tar.gz 
6ddf3758cfa7f978811002ce426da4b0  ovirt-engine-sdk-python-4.1.3.tar.gz

Comment 5 Pavol Brilla 2017-04-11 10:54:17 UTC
Check of package: 

https://pypi.io/packages/source/o/ovirt-engine-sdk-python/ovirt-engine-sdk-python-4.1.3.tar.gz 

contains examples directory.

But those 2 sources dont have same checksum

Source: https://pypi.io/packages/...
$ md5sum ovirt-engine-sdk-python-4.1.3.tar.gz 
20874fd9062072879e1786749f6be40f  ovirt-engine-sdk-python-4.1.3.tar.gz

Source: http://resources.ovirt.org/pub/...
$ md5sum ovirt-engine-sdk-python-4.1.3.tar.gz 
6ddf3758cfa7f978811002ce426da4b0  ovirt-engine-sdk-python-4.1.3.tar.gz


Note You need to log in before you can comment on or make changes to this bug.