Bug 1422989 - hardlink building issue in F26 armv7hl and i686
Summary: hardlink building issue in F26 armv7hl and i686
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: hardlink
Version: rawhide
Hardware: i686
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Francisco Javier Tsao Santín
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1423702 (view as bug list)
Depends On:
Blocks: F26FTBFS
TreeView+ depends on / blocked
 
Reported: 2017-02-16 18:36 UTC by Francisco Javier Tsao Santín
Modified: 2017-02-17 15:29 UTC (History)
4 users (show)

Fixed In Version: 1.2-1
Doc Type: Bug Fix
Doc Text:
Cause: inline declarations written for GNU89 Consequence: package doesn't compile with gcc7 in 32bits Fix: Updated to C99 standard Result: package builds again
Clone Of:
Environment:
Last Closed: 2017-02-16 19:21:57 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Francisco Javier Tsao Santín 2017-02-16 18:36:22 UTC 
Description of problem:
hardlink builds fail in 32-bit architectures

Version-Release number of selected component (if applicable):
1.1-4

How reproducible:

+ gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m32 -march=i686 -fasynchronous-unwind-tables hardlink.c -o hardlink
/tmp/cc1xWk9j.o: In function `rf':
/builddir/build/BUILD/hardlink-1.1/hardlink.c:257: undefined reference to `stcmp'
collect2: error: ld returned 1 exit status

Steps to Reproduce:
1. F26 build 
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Francisco Javier Tsao Santín 2017-02-16 19:21:57 UTC 
Following the advice by Jakub Jelinek, I fixed modifying the inline declarations in this way for a better C99 compatibility:
 
__attribute__((always_inline)) inline int stcmp(struct stat *st1, struct stat *st2, int content_only)

Pushed the solution to Rawhide.
Comment 2 Francisco Javier Tsao Santín 2017-02-17 15:29:41 UTC 
*** Bug 1423702 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.