Bug 1423377 - Review Request: prelude-lml-rules
Summary: Review Request: prelude-lml-rules
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-17 07:46 UTC by Thomas Andrejak
Modified: 2017-03-10 11:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-03 03:49:59 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Thomas Andrejak 2017-02-17 07:46:20 UTC
This is the continuation of #1386938 . This ticket is for prelude-lml-rules.It contains rules for prelude-lml (#1417405)

Description in spec :
Rules for Prelude LML contributed by the community.

SPEC : https://fedorapeople.org/~totol/prelude-lml-rules.spec
SRPM : https://fedorapeople.org/~totol/prelude-lml-rules-3.1.0-1.fc26.src.rpm
Build : https://koji.fedoraproject.org/koji/taskinfo?taskID=17911910

Thanks for the review

Regards

Thomas

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-02-17 21:41:34 UTC
> test -z "`%{buildroot}%{_bindir}/%{name}-check %{buildroot}%{_sysconfdir}/prelude-lml/ruleset/*.rules 2>&1 | grep WARNING`"
\! %{buildroot}%{_bindir}/%{name}-check %{buildroot}%{_sysconfdir}/prelude-lml/ruleset/*.rules |& grep WARNING

Apart from being simpler, this has the advantage of printing the warnings.

+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ package builds and installs in mock
+ provides/requires/BR look OK
+ %check is present and passes
+ no scriptlets

Package is APPROVED.

Comment 2 Gwyn Ciesla 2017-02-21 13:43:37 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/prelude-lml-rules

Comment 3 Fedora Update System 2017-02-21 23:09:06 UTC
prelude-lml-rules-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fbf6d92b64

Comment 4 Fedora Update System 2017-02-21 23:09:13 UTC
prelude-lml-rules-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b1e2ea3453

Comment 5 Fedora Update System 2017-02-21 23:09:18 UTC
prelude-lml-rules-3.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6bd5b4f901

Comment 6 Fedora Update System 2017-02-22 18:20:02 UTC
prelude-lml-rules-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6bd5b4f901

Comment 7 Fedora Update System 2017-02-22 18:53:10 UTC
prelude-lml-rules-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fbf6d92b64

Comment 8 Fedora Update System 2017-02-22 21:08:53 UTC
prelude-lml-rules-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b1e2ea3453

Comment 9 Fedora Update System 2017-03-03 03:49:59 UTC
prelude-lml-rules-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-03-03 03:54:28 UTC
prelude-lml-rules-3.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2017-03-10 11:20:00 UTC
prelude-lml-rules-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.