Bug 1423413 - Self-heal fail an WORMed-Files
Summary: Self-heal fail an WORMed-Files
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: selfheal
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: david.spisla
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-17 09:35 UTC by david.spisla
Modified: 2017-05-30 18:44 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:44:10 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description david.spisla 2017-02-17 09:35:58 UTC
Description of problem:
Self-Heal-Daemon can not trigger this FOPs to a WORMed-File:
link, unlink, rename, write, truncate

Self-Heal-Daemon will message a "success", but in the brick-logs there is a error message for this FOPs.

Version-Release number of selected component (if applicable): 3.8.8


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-02-17 12:10:04 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, trauncate, rename and write OP) posted (#1) for review on master by David Spisla

Comment 2 Worker Ant 2017-02-17 14:15:52 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, truncate, rename and write OP on WORMed-Files) posted (#2) for review on master by David Spisla

Comment 3 Worker Ant 2017-03-02 07:48:15 UTC
REVIEW: https://review.gluster.org/16661 (topic: xlators/worm : Bypass worm files for internal operations) posted (#3) for review on master by David Spisla (david.spisla)

Comment 4 Worker Ant 2017-03-02 07:49:02 UTC
REVIEW: https://review.gluster.org/16661 (xlators/worm : Bypass worm files for internal operations) posted (#4) for review on master by David Spisla (david.spisla)

Comment 5 Worker Ant 2017-03-15 12:02:32 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, trauncate, rename and write OP) posted (#5) for review on master by David Spisla (david.spisla)

Comment 6 Worker Ant 2017-03-15 12:26:17 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, trauncate, rename and write OP) posted (#6) for review on master by David Spisla (david.spisla)

Comment 7 Worker Ant 2017-03-15 12:27:08 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, trauncate, rename and write OP) posted (#7) for review on master by David Spisla (david.spisla)

Comment 8 Worker Ant 2017-03-23 09:19:53 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, trauncate, rename and write OP) posted (#8) for review on master by David Spisla (david.spisla)

Comment 9 Worker Ant 2017-03-23 09:19:56 UTC
REVIEW: https://review.gluster.org/16940 (Changing the the file worm.c. Self-healing can now be triggered on unlink, link, truncate, rename and write) posted (#1) for review on master by David Spisla (david.spisla)

Comment 10 Worker Ant 2017-03-27 10:18:49 UTC
REVIEW: https://review.gluster.org/16661 (Patch vor worm.c. Now Self-heal-Daemon can trigger unlink, link, trauncate, rename and write OP) posted (#9) for review on master by David Spisla (david.spisla)

Comment 11 Worker Ant 2017-04-10 12:08:01 UTC
REVIEW: https://review.gluster.org/16661 (worm: allow Self-heal-Daemon to perform some operations) posted (#10) for review on master by Niels de Vos (ndevos)

Comment 12 Worker Ant 2017-04-12 11:27:12 UTC
COMMIT: https://review.gluster.org/16661 committed in master by Niels de Vos (ndevos) 
------
commit 1b01bdcc8effb9b5342edbe669b9e2b2c36bfc80
Author: David Spisla <david.spisla>
Date:   Fri Feb 17 13:06:44 2017 +0100

    worm: allow Self-heal-Daemon to perform some operations
    
    The Self-Heal-Daemon should be allowed to trigger unlink, link,
    trauncate, rename and write operation. The value of frame->root->pid
    can be used to detect internal (by SHD) operations.
    
    Change-Id: I7526148100bef1e2837d69df5c119dc97d91fffd
    BUG: 1423413
    Signed-off-by: David Spisla <david.spisla>
    Reviewed-on: https://review.gluster.org/16661
    Tested-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Amar Tumballi <amarts>

Comment 13 Worker Ant 2017-04-13 06:14:11 UTC
REVIEW: https://review.gluster.org/17048 (worm: add check for internal processes in ftruncate()) posted (#1) for review on master by Amar Tumballi (amarts)

Comment 14 Worker Ant 2017-04-13 17:40:37 UTC
REVIEW: https://review.gluster.org/17048 (worm: add check for internal processes in ftruncate()) posted (#2) for review on master by Amar Tumballi (amarts)

Comment 15 Worker Ant 2017-04-13 17:41:52 UTC
REVIEW: https://review.gluster.org/17048 (worm: add check for internal processes in ftruncate()) posted (#3) for review on master by Amar Tumballi (amarts)

Comment 16 Worker Ant 2017-04-18 05:56:31 UTC
REVIEW: https://review.gluster.org/17048 (worm: add check for internal processes in ftruncate()) posted (#4) for review on master by Amar Tumballi (amarts)

Comment 17 Worker Ant 2017-04-18 18:35:15 UTC
COMMIT: https://review.gluster.org/17048 committed in master by Vijay Bellur (vbellur) 
------
commit c1e61fd5dfd118830e896a45d398a2041006d74e
Author: Amar Tumballi <amarts>
Date:   Thu Apr 13 11:38:08 2017 +0530

    worm: add check for internal processes in ftruncate()
    
    The patch fixes the recently seen issues with worm_sh.t test.
    
    RCA:
    
    -
    $ git log --oneline xlators/features/read-only/src/worm.c
    1b01bdc worm: allow Self-heal-Daemon to perform some operations
    c5a4a77 features/worm: Adding implementation for ftruncate
    -
    
    These two patches were merged in reverse order of their submission,
    and hence the check added for internal processes got missed in
    new fop 'ftruncate()'. The worm_sh.t passed the tests as while
    that patch got submitted there was no ftruncate() in worm xlator.
    
    Change-Id: I81a8a45fa2679917a2c859c4f5224a2c3edbc784
    BUG: 1423413
    Signed-off-by: Amar Tumballi <amarts>
    Reviewed-on: https://review.gluster.org/17048
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-by: David Spisla <david.spisla>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 18 Shyamsundar 2017-05-30 18:44:10 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.