Description of problem: Run upgrade_control_plane.yml to upgrade masters, playbook can not proceed because a syntax problem of storage_upgrade.yml. ERROR! 'inlcude' is not a valid attribute for a Play The error appears to have been in '/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_5/upgrade_control_plane.yml': line 111, column 3, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: - inlcude: ../../../../common/openshift-cluster/upgrades/v3_5/storage_upgrade.yml ^ here --------------------------------------------------------------------------- Change "inlcude" to "include" manually to run upgrade again, still failed for another error. ERROR! the role 'openshift_cli' was not found in /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_5/../../../../common/openshift-cluster/upgrades/v3_5/roles:/etc/ansible/roles:/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_5/../../../../common/openshift-cluster/upgrades/v3_5 The error appears to have been in '/usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/v3_5/storage_upgrade.yml': line 8, column 5, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: roles: - { role: openshift_cli } ^ here Version-Release number of selected component (if applicable): atomic-openshift-utils-3.5.10-1.git.0.ba66b63.el7.noarch ansible-2.2.1.0-2.el7.noarch How reproducible: always Steps to Reproduce: 1. containerized install ocp on rhel hosts. 2. trigger upgrade from 3.4 to 3.5 # ansible-playbook -i /tmp/hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_5/upgrade_control_plane.yml Actual results: Fail to start upgrade process. Expected results: Upgrade successfully. Additional info:
https://github.com/openshift/openshift-ansible/pull/3401
Commit pushed to master at https://github.com/openshift/openshift-ansible https://github.com/openshift/openshift-ansible/commit/11f0e203e81d1aa0571fd57b566b452ddf59eb49 Fix typo, add symlinks for roles Fixes Bug 1423425
# cat playbooks/byo/openshift-cluster/upgrades/v3_5/upgrade.yml | grep storage - include: ../../../../common/openshift-cluster/upgrades/v3_5/storage_upgrade.yml # cat playbooks/byo/openshift-cluster/upgrades/v3_5/upgrade_control_plane.yml | grep storage - include: ../../../../common/openshift-cluster/upgrades/v3_5/storage_upgrade.yml # ls -la common/openshift-cluster/upgrades/v3_5/ | grep roles lrwxrwxrwx. 1 root root 21 Feb 21 23:40 roles -> ../../../../../roles/ Version: atomic-openshift-utils-3.5.13-1.git.0.562e91d.el7.noarch Steps： 1. upgrade ocp3.4 to 3.5(for containerized env) Upgrade can be launched and proceed successfully.