Bug 1423471 - Amanda does nothing when running amdump
Summary: Amanda does nothing when running amdump
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: amanda
Version: 25
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-17 11:59 UTC by Nuno Dias
Modified: 2017-05-11 14:19 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-05-11 14:19:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Use function that doesn't segfault when one of its arguments is NULL (415 bytes, patch)
2017-02-20 18:52 UTC, Uwe Menges
no flags Details | Diff

Description Nuno Dias 2017-02-17 11:59:21 UTC
Description of problem:
Since the upgrade to 3.4.2-1 when running amdump nothing happens, or in other words, amdump runs but don't dump anything, don't even estimate anything, when I do a amstatus I only have the SUMMARY don't have the list of machines/disks 

Version-Release number of selected component (if applicable):
amanda-libs-3.4.2-1.fc25.x86_64
amanda-3.4.2-1.fc25.x86_64
amanda-client-3.4.2-1.fc25.x86_64
amanda-server-3.4.2-1.fc25.x86_64


How reproducible:
every time

Steps to Reproduce:
1. Update amanda to the last version
2. run amdump XXXX
3.

Actual results:
Do nothing

Expected results:


Additional info:

Comment 1 Jason Tibbitts 2017-02-17 16:45:18 UTC
Can't reproduce that here, and your report is very light on details.

Was 3.4.1 OK?  The changes in 3.4.2 aren't all that significant so that would help to narrow down the issue.

Does amdump provide an exit code?  Run "amdump XXXX; echo $?".

Is there anything relevant in /var/log/amanda?

Does "ausearch -m avc" show anything relating to amanda?

Does "amcheck --client-verbose XXX" tell you anything?

Your amanda.conf and disklist might also be useful to have on hand, but I doubt that there's any obvious issue in there.

Comment 2 Nuno Dias 2017-02-20 15:04:36 UTC
Yes, 3.4.1 works as expected, no problem.

$ amdump XXXXX; echo $? (XXXXX is my config)
9

Nothing in the logs, like error of something.

$ ausearch -m avc
<no matches>

$ amcheck --client-verbose XXXXX

Everything with OK:

The only relevant thing I can see is in log this line

"WARNING driver WARNING: got empty schedule from planner"

Comment 3 Jason Tibbitts 2017-02-20 17:04:39 UTC
Exit code 9 means "error || RESULT_MISSING" which is pretty much what I'd expect from what you describe.

Unfortunately I'm out of ideas.  I know there are some selinux issues with 3.4 in general but if 3.4.1 worked and ausearch doesn't turn anything up then I guess it isn't that.  I will report your problem upstream to see if they have any requests, though they may not be able to do much without the verbose logs and config file.

Comment 4 Uwe Menges 2017-02-20 18:52:34 UTC
Created attachment 1255849 [details]
Use function that doesn't segfault when one of its arguments is NULL

From: Jean-Louis Martineau <JMartineau>
Message-ID: <bcf3a408-d9c6-4b4d-66de-61a7126cd089>

Comment 5 Uwe Menges 2017-02-20 18:53:41 UTC
I just had a similar case, it was caused by segfault of planner.

You can verify with eg. "journalctl -b | grep planner". If it shows something like "kernel: planner[22396]: segfault at 0 ip 00007f600d98647a sp 00007ffecb94c238 error 4 in libc-2.23.so[7f600d8ea000+1b9000]", it's probably the same issue. Planner gets segfault, can't deliver schedule, therefore "got empty schedule from planner".

Proposed patch from JLM attached.

Comment 6 Jason Tibbitts 2017-02-20 18:54:40 UTC
Ah, so this is the same thing.  A segfault wasn't mentioned in this report.

Let me apply that patch and do a test build for you.

Comment 7 Fedora Update System 2017-02-20 21:31:14 UTC
amanda-3.4.2-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b2412dfc61

Comment 8 Fedora Update System 2017-02-20 21:31:25 UTC
amanda-3.4.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b5c7cd045

Comment 9 Nuno Dias 2017-02-21 10:41:43 UTC
I can confirm the segfault

kernel: planner[11717]: segfault at 0 ip 00007efe681bda66 sp 00007fff9870f178 error 4 in libc-2.24.so[7efe6806e000+1bd000]

For some reason I missed this, I'm going to test the update

Comment 10 Nuno Dias 2017-02-22 09:54:08 UTC
The updated rpm works as expected, I don't have anymore the segfault in planner and the backup finish successful.

Comment 11 Jason Tibbitts 2017-02-22 15:31:38 UTC
Please give testing feedback directly on the update if you can.

Comment 12 Nuno Dias 2017-02-22 16:04:00 UTC
done.

Comment 13 Fedora Update System 2017-02-22 18:51:54 UTC
amanda-3.4.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b5c7cd045

Comment 14 Fedora Update System 2017-02-22 21:07:27 UTC
amanda-3.4.2-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b2412dfc61

Comment 15 Fedora Update System 2017-03-01 15:04:05 UTC
amanda-3.4.2-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0ac18bda03

Comment 16 Fedora Update System 2017-03-01 15:04:20 UTC
amanda-3.4.2-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-41e61e4f94

Comment 17 Jason Tibbitts 2017-05-11 14:19:01 UTC
This was never closed because the above updates were superseded by an update to 3.4.3 which didn't reference this bug.  We're on 3.4.4 now and unless it regressed this should be fixed.


Note You need to log in before you can comment on or make changes to this bug.