Spec URL: https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php.spec SRPM URL: https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php-0.4.1-1.fc26.src.rpm Description: A fork of pablotron's zip streaming library, a fast and simple streaming zip file downloader for PHP. Fedora Account System Username: bowlofeggs
Created attachment 1255673 [details] phpci.log Note: phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 09:56:36 CET static analyze results
Created attachment 1255674 [details] review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1424721 Buildroot used: fedora-rawhide-x86_64
[!]: Package complies to the Packaging Guidelines From PHP Guildelines A PSR-4 [2] compliant library would put its PHP files in /usr/share/php/<Vendor Name> in a PSR-0 compliant tree. So should be /usr/share/php/ZipStream BTW, as "vendor" is missing, To avoid possible conflict with a too generic name, I'm fine with : /usr/share/php/maennchen/ZipStream /usr/share/php/maennchen/zipstream-php => Packager choice. [!]: Requires correct, justified where necessary. From composer.json "require": { "php": ">= 5.6", "ext-mbstring": "*" }, From phpcompatinfo report Requires PHP 5.3.0 (min), PHP 5.3.0 (all) This usually means upstream don't want to support EOL PHP version. => packager choise Do you need it in EPEL ? (build ok en epel-6 and epel-7) Tips: --bootstrap is not needed when the value in already defined in phpunit.xml --no-coverage avoid the "Error: No code coverage driver is available" (but requires phpunit > 4) No blocker, please just confirm PHP minimal version you want to support and file location.
(In reply to Remi Collet from comment #3) > [!]: Package complies to the Packaging Guidelines > > From PHP Guildelines > A PSR-4 [2] compliant library would put its PHP files in > /usr/share/php/<Vendor Name> in a PSR-0 compliant tree. > > So should be /usr/share/php/ZipStream Hello Remi! Oh I didn't realize that the string "ZipStream" inside the composer.json's psr section was a clue about where the package should be installed. I assumed that the vendor from packagist should be used. Now I understand better, thanks! I've opted to go with ZipStream as you suggested above. If we hit a conflict later, we can fix it at that time I believe. > [!]: Requires correct, justified where necessary. > > From composer.json > > "require": { > "php": ">= 5.6", > "ext-mbstring": "*" > }, > From phpcompatinfo report > > Requires PHP 5.3.0 (min), PHP 5.3.0 (all) > > This usually means upstream don't want to support EOL PHP version. > => packager choise > > Do you need it in EPEL ? (build ok en epel-6 and epel-7) I've updated it to be 5.6 to reflect upstream's wishes. I don't plan to put Ampache into EPEL 6 or 7 at this time, so this package doesn't need to go there either (but I'm willing to add it later if requested). > Tips: > > --bootstrap is not needed when the value in already defined in phpunit.xml > --no-coverage avoid the "Error: No code coverage driver is available" (but > requires phpunit > 4) I've made both of these changes as well. New files here: Spec URL: https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php.spec SRPM URL: https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php-0.4.1-2.fc26.src.rpm
-%{_datadir}/php/maennchen +%{_datadir}/php/ZipStream [x]: Package complies to the Packaging Guidelines -Requires: php(language) >= 5.3.0 +Requires: php(language) >= 5.6.0 [x]: Requires correct, justified where necessary. === APPROVED ===
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-maennchen-zipstream-php
php-maennchen-zipstream-php-0.4.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9280fac9c0
php-maennchen-zipstream-php-0.4.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d576b8eb4
Damn, I miss, this package must be "noarch" Please fix before pushing to repo
Forget, and sorry for the noise
php-maennchen-zipstream-php-0.4.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d576b8eb4
php-maennchen-zipstream-php-0.4.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9280fac9c0
php-maennchen-zipstream-php-0.4.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.