Bug 1424729 - [EWeekdayChooser] Selected days drawn with incorrect color
Summary: [EWeekdayChooser] Selected days drawn with incorrect color
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: evolution
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-18 21:12 UTC by K
Modified: 2017-02-20 14:31 UTC (History)
5 users (show)

Fixed In Version: evolution-3.23.91 evolution-3.22.6
Clone Of:
Environment:
Last Closed: 2017-02-20 13:07:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Appointment dialog in dark mode (65.86 KB, image/png)
2017-02-18 21:19 UTC, K
no flags Details
Appointment dialog in light mode (67.29 KB, image/png)
2017-02-18 21:20 UTC, K
no flags Details

Description K 2017-02-18 21:12:57 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 K 2017-02-18 21:18:56 UTC
Ah, fudge. Somehow posted this one without filling it in first. Anyway, sorry about that. Here goes.


Description of problem:
Trying to set the recurrence of an appointment when I've enabled "global dark theme" in Gnome Tweak Tools, I can't see the difference (well, just barely, if I squint from about 4 feet away.)  In light mode, the difference is clear.

I am attaching a couple of screen shots to show the problem.  Notice that SUN is selected in both cases, if you can.


Version-Release number of selected component (if applicable): 3.22.5

Comment 2 K 2017-02-18 21:19:36 UTC
Created attachment 1255289 [details]
Appointment dialog in dark mode

Comment 3 K 2017-02-18 21:20:19 UTC
Created attachment 1255290 [details]
Appointment dialog in light mode

Comment 4 Milan Crha 2017-02-20 10:58:07 UTC
Thanks for a bug report. I thought you speak about the Preview part of the dialog (which misbehaves in some cases too), but this is about the selection of the week day(s), where the 'Sun' week day at the top is drawn with a white/black font color in the light theme, but with a white color in the dark theme.

Comment 5 Milan Crha 2017-02-20 13:07:23 UTC
While the selected days in Recurrences tab of an appointment's week(s) occurrence type were meant to be drawn with selected color background, it wasn't the case, thus it could be hard to notice on some themes, notably on a GNOME dark theme.

I fixed this with the below commit for the next development release.

Created commit 3b9657e in evo master (3.23.91+) [1]

[1] https://git.gnome.org/browse/evolution/commit/?id=3b9657e

Comment 6 Milan Crha 2017-02-20 14:31:00 UTC
I decided to create a 3.22.6 release, thus I committed the same change also to the stable branch:

Created commit ca27976 in evo gnome-3-22 (3.22.6+)

[2] https://git.gnome.org/browse/evolution/commit/?id=ca27976


Note You need to log in before you can comment on or make changes to this bug.