Bug 1424791 - Coverty scan detect a potential free on uninitialised pointer in error code path
Summary: Coverty scan detect a potential free on uninitialised pointer in error code path
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: jbr
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael S.
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-19 13:56 UTC by Michael S.
Modified: 2017-05-30 18:44 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:44:34 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Michael S. 2017-02-19 13:56:03 UTC
Description of problem:
There is a few case where path will be freed with a unitiliased value (see https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-17-8e7a8ea8/html/1/725jbr-cg.c.html#error ). While that's likely not exploitable, that may cause a crash of gluster.

Version-Release number of selected component (if applicable):
git master

How reproducible:
each time

Steps to Reproduce:
1. read the coverty report
2.
3.

Actual results:
there is a error

Expected results:
no error

Additional info:

Comment 1 Worker Ant 2017-02-19 13:56:25 UTC
REVIEW: https://review.gluster.org/16670 (Initialize path, since coverty detect a code path where we do a free on a unitialized pointer (if jbr_get_changelog_dir fail).) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-02-20 23:33:03 UTC
COMMIT: https://review.gluster.org/16670 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 6b42f96d148f0bf36149346196edf5d42bf74941
Author: Michael Scherer <misc>
Date:   Sun Feb 19 14:51:27 2017 +0100

    Initialize path, since coverty detect a code path where
    we do a free on a unitialized pointer
    (if jbr_get_changelog_dir fail).
    
    Change-Id: Ib68122bb9eddaeb422028f834856a0776ecbb789
    BUG: 1424791
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/16670
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Nigel Babu <nigelb>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-05-30 18:44:34 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.