Bug 1424793 - Missing verification of fcntl return code
Summary: Missing verification of fcntl return code
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael S.
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-19 14:18 UTC by Michael S.
Modified: 2017-05-30 18:44 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:44:34 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Michael S. 2017-02-19 14:18:49 UTC
Description of problem:

Coverty return a warning 
https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-17-8e7a8ea8/html/1/52event.c.html#error

There is however no verification that the operation failed, and while a quick look show that this is not a problem (that's in a destroy operation), that help to remove noise from coverty report.

Version-Release number of selected component (if applicable):
621fedf8aeb3


How reproducible:
each time

Steps to Reproduce:
1.look at coverty report
2.
3.

Actual results:
fnctl return is not checked

Expected results:
fnctl should be checked

Additional info:

Comment 1 Worker Ant 2017-02-19 14:20:29 UTC
REVIEW: https://review.gluster.org/16671 (Properly verify the return code of fcntl) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-02-23 11:59:14 UTC
COMMIT: https://review.gluster.org/16671 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit afe3a0d2869b706a3d5257f39d6acb9cbe856b87
Author: Michael Scherer <misc>
Date:   Sun Feb 19 15:18:56 2017 +0100

    Properly verify the return code of fcntl
    
    Coverty scan complain about it, even if in practice, this
    doesn't seems to have much impact.
    
    Change-Id: I513f7d393889625d22dded25ef4c7477f68d1064
    BUG: 1424793
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/16671
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Nigel Babu <nigelb>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>

Comment 3 Shyamsundar 2017-05-30 18:44:34 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.