Description of problem: See https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-17-8e7a8ea8/html/1/81glusterd-store.c.html#error Version-Release number of selected component (if applicable): How reproducible: each time Steps to Reproduce: 1. read the code 2. read the error 3. Actual results: There is useless code Expected results: No useless code Additional info:
REVIEW: https://review.gluster.org/16674 (Remove the useless goto) posted (#1) for review on master by Michael Scherer (misc)
COMMIT: https://review.gluster.org/16674 committed in master by Atin Mukherjee (amukherj) ------ commit 37772e8e94400a60aedcd6713b1abedb1eb9ea7f Author: Michael Scherer <misc> Date: Sun Feb 19 16:38:24 2017 +0100 Remove the useless goto ret cannot be 0, since the error code for gf_store_save_value is -1. And the label of the goto is just after the goto, so that's deadcode. Change-Id: I227bca41f4d0755891b8e6e0f4cb2ce004615a35 BUG: 1424809 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16674 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Nigel Babu <nigelb> Reviewed-by: Atin Mukherjee <amukherj> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> CentOS-regression: Gluster Build System <jenkins.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report. glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html [2] https://www.gluster.org/pipermail/gluster-users/