Bug 1424813 - [UI] - Can't make any changes in custom mode field after pressed on 'OK' button one time
Summary: [UI] - Can't make any changes in custom mode field after pressed on 'OK' butt...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 4.1.1.2
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: ovirt-4.1.1
: 4.1.1.3
Assignee: Dominik Holler
QA Contact: Meni Yakove
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-19 15:49 UTC by Michael Burman
Modified: 2017-04-21 09:46 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-04-21 09:46:36 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.1+
ylavi: exception+


Attachments (Terms of Use)
record (8.22 MB, application/x-gzip)
2017-02-19 15:51 UTC, Michael Burman
no flags Details
new record (9.01 MB, application/x-gzip)
2017-03-06 07:39 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 72713 0 master MERGED webadmin: Move updateBondOptions to SetupNetworksBondModel 2017-02-24 13:15:15 UTC
oVirt gerrit 73044 0 ovirt-engine-4.1 MERGED webadmin: Move updateBondOptions to SetupNetworksBondModel 2017-02-26 12:48:21 UTC
oVirt gerrit 73050 0 ovirt-engine-4.1.1.z MERGED webadmin: Move updateBondOptions to SetupNetworksBondModel 2017-02-27 13:55:02 UTC

Description Michael Burman 2017-02-19 15:49:02 UTC
Description of problem:
[UI] - Can't make any changes in custom mode field after pressed on 'OK' button one time.

Version-Release number of selected component (if applicable):
4.1.1.2-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. Create bond in ui setup networks with custom bond mode 'mode=1' and press 'OK'
2. Press the edit pencil of the bond again and press 'OK' again (can't)
3. Press 'Cancel' and 'OK' on the setup network sdialog
4. Try to edit the bond with different mode

Actual results:
2. Field colored in red
4. Field colored in red

Expected results:
Should work as expected

Additional info:
Attaching record to describe the issue

Comment 1 Michael Burman 2017-02-19 15:51:05 UTC
Created attachment 1255474 [details]
record

Comment 2 Michael Burman 2017-03-06 07:30:39 UTC
Dominik, 

Failing QA, as it partially fixed. 

Steps to Reproduce:
1. Create bond in ui setup networks with custom bond mode 'mode=1' and press 'OK'
2. Press the edit pencil of the bond again and press 'OK' again (can)
3. Press 'OK' on the setup networks dialog
4. Try to edit the bond with different mode

Actual results:
2. Fixed
4. Field colored in red. Doesn't fixed. 
It is still not possible to change the custom mode after it was created once.

Comment 3 Red Hat Bugzilla Rules Engine 2017-03-06 07:30:47 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 4 Michael Burman 2017-03-06 07:39:57 UTC
Created attachment 1260289 [details]
new record

Comment 5 Dominik Holler 2017-03-06 07:59:35 UTC
The reason for 4. in comment #2 is a leading space in the custom bonding options.
It has the same reason like problem 1) in https://bugzilla.redhat.com/show_bug.cgi?id=1412563 , which is already fixed in the master.

Comment 6 Dan Kenigsberg 2017-03-06 08:56:49 UTC
Michael, please VERIFY this bug, while keeping a miimon=NNN value. The leading space issue is not related to this webadmin bug.

If you find the leading space issue too troublesome, please file a new bug for it and we can consider backporting it (though we do not want to).

Comment 7 Michael Burman 2017-03-06 09:00:32 UTC
Dan, How can i verify it , if the gap causing to this issue in the first place? 
It is related, the gap preventing from changing the mode to something else.

Comment 8 Dan Kenigsberg 2017-03-07 06:52:34 UTC
If you set miimon=200 on your custom options, you won't see the leading space. The UI issue solved by this patch would have remained in earlier versions, but solved in 4.1.1.3

Comment 9 Michael Burman 2017-03-07 07:07:46 UTC
Fine, as you wish. 

New bug reported for the gap issue. See bz 1429810

Verified on - 4.1.1.3-0.1.el7


Note You need to log in before you can comment on or make changes to this bug.