Bug 1424894 - Some switches don't have breaks causing unintended fall throughs.
Summary: Some switches don't have breaks causing unintended fall throughs.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nigel Babu
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-20 02:56 UTC by Nigel Babu
Modified: 2017-05-30 18:44 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:44:34 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Nigel Babu 2017-02-20 02:56:01 UTC
Coverity has caught a few instances of switches not having a break causing unintentional fall through.

Comment 1 Worker Ant 2017-02-20 03:31:05 UTC
REVIEW: https://review.gluster.org/16677 (Add missing breaks to the switch) posted (#1) for review on master by Nigel Babu (nigelb)

Comment 2 Worker Ant 2017-02-24 10:28:05 UTC
REVIEW: https://review.gluster.org/16677 (libglusterfs, gfdb, glusterfs: Add missing breaks) posted (#2) for review on master by Nigel Babu (nigelb)

Comment 3 Worker Ant 2017-02-26 16:29:30 UTC
COMMIT: https://review.gluster.org/16677 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 688abcc90745515f7e143ef8cf1e938239db597c
Author: Nigel Babu <nigelb>
Date:   Mon Feb 20 08:27:51 2017 +0530

    libglusterfs, gfdb, glusterfs: Add missing breaks
    
    A few switches did not have breaks causing fall throughs. Most of them
    have been fixed with fall through comments for those that are
    intentional.
    
    Change-Id: I84c85726b542f38504b50fefab5eba5dbcd27a07
    BUG: 1424894
    Signed-off-by: Nigel Babu <nigelb>
    Reviewed-on: https://review.gluster.org/16677
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 4 Shyamsundar 2017-05-30 18:44:34 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.