Bug 1425307 - Fix statvfs for FreeBSD in Python
Summary: Fix statvfs for FreeBSD in Python
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: 3.8
Hardware: Unspecified
OS: FreeBSD
unspecified
unspecified
Target Milestone: ---
Assignee: Xavi Hernandez
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: glusterfs-3.8.10
TreeView+ depends on / blocked
 
Reported: 2017-02-21 07:27 UTC by Xavi Hernandez
Modified: 2017-03-18 10:52 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8.10
Clone Of:
Environment:
Last Closed: 2017-03-18 10:52:28 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1411899 0 unspecified CLOSED DHT doesn't evenly balance files on FreeBSD with ZFS 2021-02-22 00:41:40 UTC

Internal Links: 1411899

Description Xavi Hernandez 2017-02-21 07:27:05 UTC
Description of problem:

The function statvfs() in FreeBSD has a different meaning for field f_bsize. This needs to be fixed in a Python script that uses it.

Version-Release number of selected component (if applicable): 3.8.9


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-02-21 07:30:37 UTC
REVIEW: https://review.gluster.org/16634 (extras/rebalance.py: Fix statvfs for FreeBSD in python) posted (#2) for review on release-3.8 by Xavier Hernandez (xhernandez)

Comment 2 Worker Ant 2017-03-10 22:41:05 UTC
COMMIT: https://review.gluster.org/16634 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit f7152df58b0349d3411ecadb476890ec934007dd
Author: Xavier Hernandez <xhernandez>
Date:   Wed Feb 1 10:01:26 2017 +0100

    extras/rebalance.py: Fix statvfs for FreeBSD in python
    
    FreeBSD doesn't return the block size in f_bsize as linux does. It
    returns the optimal I/O size, so we need to consider this to avoid
    invalid results. On FreeBSD we take f_frsize as the block size.
    
    > Change-Id: I72083d8ae183548439de874c77f1d60d9c2d14a7
    > BUG: 1356076
    > Signed-off-by: Xavier Hernandez <xhernandez>
    > Reviewed-on: https://review.gluster.org/16498
    > CentOS-regression: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    Change-Id: I2ec327ca2c185716294a33c9ee8ca25fab70da8c
    BUG: 1425307
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: https://review.gluster.org/16634
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2017-03-18 10:52:28 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.10, please open a new bug report.

glusterfs-3.8.10 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-March/000068.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.