Red Hat Bugzilla – Bug 1425591
Unable to create snapshot If there is no active snapshot existing for a VM
Last modified: 2017-05-31 10:35:58 EDT
Created attachment 1256241 [details] snapshot Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. create a service with a VM . 2. create snapshot for the VM link is inactive. 3. Message on the icon says "select the active snapshot to create new snapshot for the VM". 4. Workaround : create snapshot from provider and then we can create more snapshots from CFME. Actual results: Expected results: Additional info:
Version - 5.8.0.1-nightly.20170217165449_ee3e7b9
Brian, It appears from the code that toolbar button is not available when a VM does not have any snapshots. I think we do not need the check here for @active https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/button/vm_snapshot_add.rb#L3 We should allow create Snapshot task if user's role allows the task and if back-end supports create_snapshot task for the VM. Let me know if you have questions. Thanks, ~Harpreet
https://github.com/ManageIQ/manageiq-ui-classic/pull/598
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/eb4329e659ad57f24e07bbef02bd6b88131d718d commit eb4329e659ad57f24e07bbef02bd6b88131d718d Author: Brian McLaughlin <bmclaugh@redhat.com> AuthorDate: Mon Mar 6 14:10:28 2017 -0500 Commit: Brian McLaughlin <bmclaugh@redhat.com> CommitDate: Mon Mar 6 14:11:50 2017 -0500 Allow user to create snapshot without an active snapshot https://bugzilla.redhat.com/show_bug.cgi?id=1425591 app/helpers/application_helper/button/vm_snapshot_add.rb | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/45ea663c86f0cb9ff548c2c7f145c21f0f3f5754 commit 45ea663c86f0cb9ff548c2c7f145c21f0f3f5754 Author: Brian McLaughlin <bmclaugh@redhat.com> AuthorDate: Mon Mar 6 14:11:40 2017 -0500 Commit: Brian McLaughlin <bmclaugh@redhat.com> CommitDate: Mon Mar 6 14:11:50 2017 -0500 Spec test https://bugzilla.redhat.com/show_bug.cgi?id=1425591 .../buttons/vm_snapshot_add_spec.rb | 28 ++++++++++++++-------- 1 file changed, 18 insertions(+), 10 deletions(-)
Able to create snapshot when there is no active snapshot existing for a VM. Verified:5.8.0.4.20170307183144_745a3d9
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:1367