Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1425767 - grafton-sanity-check doesn't fail when a given disk doesn't exist or disk is not blank
grafton-sanity-check doesn't fail when a given disk doesn't exist or disk is ...
Status: CLOSED WONTFIX
Product: Red Hat Gluster Storage
Classification: Red Hat
Component: gdeploy (Show other bugs)
3.2
Unspecified Unspecified
high Severity medium
: ---
: ---
Assigned To: Sachidananda Urs
SATHEESARAN
: ZStream
Depends On:
Blocks: 1433896
  Show dependency treegraph
 
Reported: 2017-02-22 06:10 EST by Ramesh N
Modified: 2018-10-22 01:38 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2018-10-22 01:38:55 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ramesh N 2017-02-22 06:10:39 EST
Description of problem:

grafton-sanity-check doesn't fail when a given disk doesn't exist or disk is not empty

Version-Release number of selected component (if applicable):
gdeploy-2.0.1-11.el7rhgs

How reproducible:
Always

Steps to Reproduce:
1. Create gdeploy configuration file like the following.
##################################################################
[hosts]
dhcp42-123.lab.eng.blr.redhat.com
dhcp43-152.lab.eng.blr.redhat.com

[script1]
action=execute
ignore_script_errors=no
file=/usr/share/ansible/gdeploy/scripts/grafton-sanity-check.sh -d vdb,xxx -h dhcp42-123.lab.eng.blr.redhat.com,dhcp43-152.lab.eng.blr.redhat.com
########################################################################

2. Give a disk name which does not exists and another disk name which is already used (Either as OS partition or as Gluster Brick)

  In the above example, disk 'vdb' is used already used for OS installation and disk 'xxx' doesn't exists in any system.

Actual results:
[root@dhcp42-123 ~]# echo $?
0
[root@dhcp42-123 ~]# 


grafton-sanity-check.sh passes and return success code 0. 


Expected results:

grafton-sanity-check.sh should fail to indicate that disk xxx doesn't exist and disk 'vdb' is not blank.
Comment 4 Sachidananda Urs 2018-10-22 01:38:55 EDT
This will be handled in gluster-ansible releases

Note You need to log in before you can comment on or make changes to this bug.