Bug 1425788 - 3.6 engine can't be restored in 4.1
Summary: 3.6 engine can't be restored in 4.1
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backup-Restore.Engine
Version: 4.1.1.2
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Yedidyah Bar David
QA Contact: Pavel Stehlik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-22 12:45 UTC by Jiri Belka
Modified: 2017-02-22 13:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-22 13:16:17 UTC
oVirt Team: Integration
Embargoed:


Attachments (Terms of Use)

Description Jiri Belka 2017-02-22 12:45:18 UTC
Description of problem:

3.6 engine can't be restored in 4.1, this will be an issue when 4.1 will be shipped into downstream channel 'rhel-7-server-rhv-4.0-rpms' :/

~~~
# sed -n -e '/^VALID_BACKUP_RESTORE_PAIRS/,+3p' -e '/^verifyVersion/,/^}$/p' `which engine-backup`
VALID_BACKUP_RESTORE_PAIRS="3.6 4.0"
# A newline-separated list of pair. E.g. if we want to allow 4.0->4.1,
#VALID_BACKUP_RESTORE_PAIRS="3.6 4.0
#4.0 4.1"
verifyVersion() {
set -x
        INSTALLED_VERSION="$(echo ${PACKAGE_VERSION} | cut -d . -f 1-2)"
        BACKUP_VERSION="$(cat ${TEMP_FOLDER}/${PACKAGE_VERSION_FILENAME} | cut -d . -f 1-2)"
        local ok=
        while read validbck validres; do
                [ "${BACKUP_VERSION}" = "${validbck}" -a "${INSTALLED_VERSION}" = "${validres}" ] && ok=1
        done << __EOF__
${VALID_BACKUP_RESTORE_PAIRS}
__EOF__
        [ "${INSTALLED_VERSION}" == "${BACKUP_VERSION}" ] && ok=1
        [ -z "${ok}" ] && logdie "Backup was created by version '${BACKUP_VERSION}' and can not be restored using the installed version ${INSTALLED_VERSION}"
}
~~~

~~~
# cat restore.log 
2017-02-22 13:38:09 1875: Start of engine-backup mode restore scope all file backup
2017-02-22 13:38:09 1875: OUTPUT: Preparing to restore:
2017-02-22 13:38:09 1875: OUTPUT: - Unpacking file 'backup'
2017-02-22 13:38:09 1875: Opening tarball backup to /tmp/engine-backup.ZHol45Ydri
2017-02-22 13:38:09 1875: Verifying md5
2017-02-22 13:38:09 1875: Verifying version
2017-02-22 13:38:09 1875: FATAL: Backup was created by version '3.6' and can not be restored using the installed version 4.1
~~~

Version-Release number of selected component (if applicable):
ovirt-engine-tools-backup-4.1.1.2-0.1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. 3.6 engine backup
2. 4.1 installation
3. do restore

Actual results:
not possible

Expected results:
should work as 4.1 will be shipped into same channel as 4.0 and thus it would be hard to get older 4.x engine

Additional info:

Comment 1 Yedidyah Bar David 2017-02-22 12:54:44 UTC
(In reply to Jiri Belka from comment #0)
> Description of problem:
> 
> 3.6 engine can't be restored in 4.1,

I think that's intended.

> this will be an issue when 4.1 will be
> shipped into downstream channel 'rhel-7-server-rhv-4.0-rpms' :/

Are you sure?

Engine does have separate channels for each x.y version.

Do you mean that the 4.0 appliance won't be available (easily) for hosted-engine upgrade tool? That's a different issue.

Comment 2 Jiri Belka 2017-02-22 13:00:09 UTC
(In reply to Yedidyah Bar David from comment #1)
> (In reply to Jiri Belka from comment #0)
> > Description of problem:
> > 
> > 3.6 engine can't be restored in 4.1,
> 
> I think that's intended.
> 
> > this will be an issue when 4.1 will be
> > shipped into downstream channel 'rhel-7-server-rhv-4.0-rpms' :/

oops, i missed this '.0' here :)                        ^^

> 
> Are you sure?
> 
> Engine does have separate channels for each x.y version.

feel free to close this bz as not bug then, sorry & thx.

Comment 3 Yedidyah Bar David 2017-02-22 13:16:17 UTC
Closing as notabug then. As hinted in the description, this is very simple to change in the code, but will require some significant QE/support commitment, so will likely not happen.


Note You need to log in before you can comment on or make changes to this bug.