Bug 1425815 - Review Request: radare2 - Reverse engineering framework
Summary: Review Request: radare2 - Reverse engineering framework
Keywords:
Status: CLOSED DUPLICATE of bug 1368855
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-22 13:50 UTC by Lubomir Rintel
Modified: 2017-08-30 10:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-30 10:49:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lubomir Rintel 2017-02-22 13:50:02 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/radare2.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/radare2-1.2.0-1.fc25.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17991451

Description:

Radare is a reverse-engineering framework that is multi-architecture,
multi-platform, and highly scriptable.  Radare provides a hexadecimal
editor, wrapped I/O, file system support, debugger support, diffing
between two functions or binaries, and code analysis at opcode,
basic block, and function levels.

Comment 1 Dmitrij S. Kryzhevich 2017-03-01 04:07:32 UTC
Well.
There are too many bundled libs here. Parts of grub, zlib, squashfs, etc. Some of them I believe could be substituted by system ones. Others... hm. You should consider to request explicit permission for bundling exclusion in fed-releng.

I'm not sure whether rar-archive support is allowed at all in Fedora. You need explicit permission from fed-legal I suppose. Rpmfusion maybe?

About spec.
1. Group tag is not required.
2. openssl and gmp support are disabled. Is it OK? If you will enable them add their -devel parts to radare2 one Require.
3. To copy .a to libdir and... exclude it? Why?
4. make %{?_smp_mflags} LIBDIR=%{_libdir} PREFIX=%{_prefix} DATADIR=%{DATADIR} HAVE_LIBVERSION=1
What is %{DATADIR} here? %{_datadir} ?

Comment 2 Lubomir Rintel 2017-08-30 10:49:45 UTC
Closing this, because there's an older review that seems to be sort of alive again.

*** This bug has been marked as a duplicate of bug 1368855 ***


Note You need to log in before you can comment on or make changes to this bug.