Bug 1425879 - NFS storage domain path with a trailing slash should be accepted
Summary: NFS storage domain path with a trailing slash should be accepted
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Benny Zlotnik
QA Contact: Lilach Zitnitski
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-22 16:17 UTC by Ondřej Svoboda
Modified: 2017-12-20 11:15 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:15:50 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+
ratamir: testing_plan_complete-


Attachments (Terms of Use)
Failing tests for / only mount paths (1.94 KB, patch)
2017-07-10 11:11 UTC, Allon Mureinik
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 72930 0 master ABANDONED engine: simplify NfsMountPointConstraint + test 2017-08-13 01:56:20 UTC
oVirt gerrit 72968 0 master ABANDONED webadmin: reuse regex from backend code in LinuxMountPointValidation 2017-08-20 01:56:20 UTC
oVirt gerrit 73285 0 master MERGED engine: Allow slash at the end of NFS mount point string 2017-07-05 07:58:24 UTC
oVirt gerrit 79214 0 master MERGED core: allow the server path to be only a slash 2017-07-10 14:05:36 UTC
oVirt gerrit 79230 0 master MERGED webadmin: allow the server path to be only a slash 2017-07-13 08:48:45 UTC
oVirt gerrit 79232 0 ovirt-engine-4.1 ABANDONED webadmin: allow the server path to be only a slash 2017-07-10 16:25:04 UTC

Description Ondřej Svoboda 2017-02-22 16:17:26 UTC
I wanted to try out adding a storage domain over IPv6 and simply copied an NFS export path from the command line, with a trailing slash (because I used tab completion).

I pasted this address into the "New Domain" dialog's "Export Path" entry: [fd8f:1391:3a82:200::c0a8:c8e2]:/exports/nfs/share1/

The path was not accepted. I got the following message: "NFS mount path is illegal, please use [IP:/path or FQDN:/path] convention."

This lead me to believe that IPv6 NFS paths were not accepted. Later, I found that they actually are, as https://bugzilla.redhat.com/show_bug.cgi?id=1302358 is already fixed.

Please allow trailing slashes in NFS export paths to avoid user confusion, or introduce a more explanatory error message in case slash-final paths are discouraged (but I don't see a reason for that).

Comment 1 Tal Nisan 2017-07-10 10:05:35 UTC
*** Bug 1468911 has been marked as a duplicate of this bug. ***

Comment 2 Allon Mureinik 2017-07-10 11:11:06 UTC
Created attachment 1295785 [details]
Failing tests for / only mount paths

The attached patches improve the situation, but don't handle mount paths like myserver.com:/

I'm attaching example tests that fail with them.

Comment 3 Allon Mureinik 2017-07-10 14:25:08 UTC
Overzealously moved to MODIFIED, returning to POST

Comment 4 Lilach Zitnitski 2017-07-30 10:49:37 UTC
--------------------------------------
Tested with the following code:
----------------------------------------
ovirt-engine-4.2.0-0.0.master.20170728194615.gitec6aa15.el7.centos.noarch
vdsm-4.20.1-269.git4afc67d.el7.centos.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. create new storage domain with trailing slash at the end of the path

Actual results:
storage domain was added successfully 

Expected results:

Moving to VERIFIED!

Comment 6 Sandro Bonazzola 2017-12-20 11:15:50 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.