Bug 1425971 - Simple problem unwrapping AES sym keys on token
Summary: Simple problem unwrapping AES sym keys on token
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: jss
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jack Magne
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1425972
TreeView+ depends on / blocked
 
Reported: 2017-02-22 22:28 UTC by Matthew Harmsen
Modified: 2017-08-08 19:40 UTC (History)
7 users (show)

Fixed In Version: jss-4.2.6-44.fc24
Clone Of:
: 1425972 (view as bug list)
Environment:
Last Closed: 2017-08-08 19:40:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Mozilla Foundation 1328675 0 None None None 2017-03-14 04:50:45 UTC

Description Matthew Harmsen 2017-02-22 22:28:02 UTC
Cloned from upstream Mozilla JSS:

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161114215916

Steps to reproduce:

I wrote some code that tries to unwrap an aes sym key on the token like this:

 aes128 = keyWrap.unwrapSymmetric(wrappedKey, SymmetricKey.AES, 16);




Actual results:

When later getting the algorithm like this:

String alg = aes128.getAlgorithm();

It was returning RCS which is incorrect. 
The cause seems to be a simple switch statement that doesn't handle AES. This will be evident in the very simple patch to follow.


Expected results:

It should give us the AES type key.

Comment 1 Matthew Harmsen 2017-02-22 22:29:20 UTC
jmagne 2017-01-04 11:33:02 PST:

Very simple patch to address this:
diff -up ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java.aes ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java
--- ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java.aes	2017-01-03 17:14:57.642278989 -0800
+++ ./jss-4.2.6.aes/mozilla/security/jss/org/mozilla/jss/pkcs11/PK11KeyWrapper.java	2017-01-03 17:44:03.220626460 -0800
@@ -617,7 +617,9 @@ final class PK11KeyWrapper implements Ke
             return EncryptionAlgorithm.DES3_ECB;
         } else if( type == SymmetricKey.RC4 ) {
             return EncryptionAlgorithm.RC4;
-        } else {
+        } else if( type == SymmetricKey.AES ) {
+            return EncryptionAlgorithm.AES_128_ECB;
+        } else  {
             Assert._assert( type == SymmetricKey.RC2 );
             return EncryptionAlgorithm.RC2_CBC;
         }

Comment 2 Fedora Update System 2017-02-23 16:03:50 UTC
jss-4.2.6-44.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3270b85563

Comment 3 Fedora Update System 2017-02-23 16:05:34 UTC
jss-4.2.6-44.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4d0fb2c154

Comment 4 Fedora Update System 2017-02-25 00:53:02 UTC
jss-4.2.6-44.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3270b85563

Comment 5 Fedora Update System 2017-02-25 01:51:55 UTC
jss-4.2.6-44.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4d0fb2c154

Comment 6 Fedora Update System 2017-02-26 00:20:27 UTC
jss-4.2.6-44.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2017-02-26 01:38:17 UTC
jss-4.2.6-44.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora End Of Life 2017-07-26 00:16:59 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 9 Fedora End Of Life 2017-08-08 19:40:17 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.