+++ This bug was initially created as a clone of Bug #1398186 +++ Description of problem: ----------------------- 4 node cluster. Do not create ganesha.conf and ganesha-ha.conf inside shared storage. Run gluster nfs-ganesha enable. The command shows "success". It would be good to have some sort of a validation check to check presence of these files.ATM,the success message on the CLI is misleading. [root@gqas013 ~]# gluster nfs-ganesha enable --mode=script This will take a few minutes to complete. Please wait .. nfs-ganesha : success [root@gqas013 ~]# [root@gqas013 ~]# ll /var/run/gluster/shared_storage/nfs-ganesha total 0 [root@gqas013 ~]# [root@gqas013 ~]# pcs status Error: cluster is not currently running on this node [root@gqas013 ~]# Version-Release number of selected component (if applicable): ------------------------------------------------------------- nfs-ganesha-gluster-2.4.1-1.el7rhgs.x86_64 glusterfs-ganesha-3.8.4-4.el7rhgs.x86_64 How reproducible: ----------------- Always. Steps to Reproduce: ------------------- Given in description. Actual results: -------------- ganesha enable shows "success" on CLI,which isn't really the case. Expected results: ------------------ Ganesha enable should throw some sort of a meaningful message on CLI,post validation. Additional info: ---------------- -
REVIEW: https://review.gluster.org/16733 (glusterd/ganesha : return proper value in pre_setup()) posted (#1) for review on release-3.10 by jiffin tony Thottan (jthottan)
REVIEW: https://review.gluster.org/16823 (ganesha/scripts : Stop ganesha process on all nodes if cluster setup fails) posted (#1) for review on release-3.10 by jiffin tony Thottan (jthottan)
COMMIT: https://review.gluster.org/16823 committed in release-3.10 by Kaleb KEITHLEY (kkeithle) ------ commit e2cbfcbf154cc7b0c95eaaf079eab7291ffdb580 Author: Jiffin Tony Thottan <jthottan> Date: Thu Mar 2 12:22:30 2017 +0530 ganesha/scripts : Stop ganesha process on all nodes if cluster setup fails During staging phase of volume option "nfs-ganesha", symlink "ganesha.conf" will be created plus ganesha process will be started. The cluster setup happens during commit phase of that option. So if cluster set up fails, the ganesha process will be running on all cluster nodes. Change-Id: Ib2cb85364b7ef5b702acb4826ffdf8e6f31a2acd BUG: 1426156 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: https://review.gluster.org/16823 Smoke: Gluster Build System <jenkins.org> Tested-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: soumya k <skoduri> Reviewed-by: Kaleb KEITHLEY <kkeithle> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org>
COMMIT: https://review.gluster.org/16733 committed in release-3.10 by Kaleb KEITHLEY (kkeithle) ------ commit 658d2b174a0f280d8ba2dde30cf9e4686312c430 Author: Jiffin Tony Thottan <jthottan> Date: Wed Feb 22 18:26:30 2017 +0530 glusterd/ganesha : return proper value in pre_setup() Change-Id: I6f7ce82488904c7d418ee078162f26f1ec81e9d9 BUG: 1426156 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: https://review.gluster.org/16733 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Raghavendra Talur <rtalur> Tested-by: Raghavendra Talur <rtalur> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org>
Since the plan is to deprecate CLIs and move to storehaug for nfs-ganesha cluster setup in the near future, this enhancement to validate invalid inputs cannot be taken.