Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1426536

Summary:	Logging/Metrics deployment options in example inventory need update
Product:	OpenShift Container Platform	Reporter:	Gaoyun Pei <gpei>
Component:	Installer	Assignee:	ewolinet
Status:	CLOSED ERRATA	QA Contact:	Gaoyun Pei <gpei>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.5.0	CC:	aos-bugs, gpei, jokerman, mmccomas, myllynen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-04-12 19:02:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1430625, 1430626, 1430627, 1430628
Bug Blocks:

Description Gaoyun Pei 2017-02-24 08:32:52 UTC

Description of problem:
Since ocp-3.5 installer start using new roles for logging and metrics deployment, most of the options for logging&metrics described in example inventory are not working now, so need to update them to new options clearly.


Version-Release number of selected component (if applicable):
openshift-ansible-3.5.13-1.git.0.562e91d.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.Check /usr/share/doc/openshift-ansible-docs-3.5.13/docs/example-inventories/hosts.ose.example

[root@gpei-test-ansible ~]# grep -e logging -e metrics /usr/share/doc/openshift-ansible-docs-3.5.13/docs/example-inventories/hosts.ose.example |grep ^#openshift
#openshift_hosted_metrics_deploy=true
#openshift_hosted_metrics_storage_kind=nfs
#openshift_hosted_metrics_storage_access_modes=['ReadWriteOnce']
#openshift_hosted_metrics_storage_nfs_directory=/exports
#openshift_hosted_metrics_storage_nfs_options='*(rw,root_squash)'
#openshift_hosted_metrics_storage_volume_name=metrics
#openshift_hosted_metrics_storage_volume_size=10Gi
#openshift_hosted_metrics_storage_kind=nfs
#openshift_hosted_metrics_storage_access_modes=['ReadWriteOnce']
#openshift_hosted_metrics_storage_host=nfs.example.com
#openshift_hosted_metrics_storage_nfs_directory=/exports
#openshift_hosted_metrics_storage_volume_name=metrics
#openshift_hosted_metrics_storage_volume_size=10Gi
#openshift_hosted_metrics_storage_kind=dynamic
#openshift_hosted_metrics_public_url=https://hawkular-metrics.example.com/hawkular/metrics
#openshift_hosted_logging_deploy=true
#openshift_hosted_logging_storage_kind=nfs
#openshift_hosted_logging_storage_access_modes=['ReadWriteOnce']
#openshift_hosted_logging_storage_nfs_directory=/exports
#openshift_hosted_logging_storage_nfs_options='*(rw,root_squash)'
#openshift_hosted_logging_storage_volume_name=logging
#openshift_hosted_logging_storage_volume_size=10Gi
#openshift_hosted_logging_storage_kind=nfs
#openshift_hosted_logging_storage_access_modes=['ReadWriteOnce']
#openshift_hosted_logging_storage_host=nfs.example.com
#openshift_hosted_logging_storage_nfs_directory=/exports
#openshift_hosted_logging_storage_volume_name=logging
#openshift_hosted_logging_storage_volume_size=10Gi
#openshift_hosted_logging_storage_kind=dynamic
#openshift_master_logging_public_url=https://kibana.example.com
#openshift_hosted_logging_elasticsearch_cluster_size=1
#openshift_hosted_logging_hostname=logging.apps.example.com
#openshift_hosted_logging_deployer_prefix=registry.example.com:8888/openshift3/
#openshift_hosted_logging_deployer_version=3.3.0

2. After a round of testing, only the following options still work now.
openshift_hosted_metrics_deploy
openshift_hosted_logging_deploy
openshift_hosted_logging_elasticsearch_cluster_size
openshift_hosted_logging_hostname
openshift_hosted_logging_deployer_prefix
openshift_hosted_logging_deployer_version


Actual results:


Expected results:


Additional info:

Comment 1 ewolinet 2017-03-02 23:59:41 UTC

What playbook are you using for your testing?

Comment 2 Gaoyun Pei 2017-03-03 00:18:49 UTC

Test with openshift-ansible-3.5.13-1.git.0.562e91d.el7.noarch.

For example, set the following two options in ansible inventory file as doc mentioned
openshift_hosted_metrics_deploy=true
openshift_hosted_metrics_storage_kind=dynamic

Then start an ocp-3.5 cluster installation
ansible-playbook -i inventory_file /usr/share/ansible/openshift-ansible/playbooks/byo/config.yml

After installation, there's no pvc created for metrics pod, the dynamic pv was not added.

Comment 5 Gaoyun Pei 2017-03-09 07:38:28 UTC

Test with these options again with openshift-ansible-3.5.28-1.git.0.103513e.el7.noarch.rpm, still not work as expected. Since the failures were different, so filed new bugs to track them separately, thanks!

BZ#1430625 - Metrics and logging deployment with dynamic pv failed
BZ#1430628 - openshift_master_logging_public_url option didn't work
BZ#1430627 - Logging deployment with NFS volume failed
BZ#1430626 - Metrics deployment with NFS volume failed

Comment 6 Gaoyun Pei 2017-03-16 05:52:31 UTC

Thanks for the quick fix on the above bugs!

After checking the logging/metrics deployment part in latest example inventory, add some suggestions here to make it better for customer use.

1) Better to add description about how to specify prefix and version for metrics components.
We were using openshift_hosted_metrics_deployer_prefix and openshift_hosted_metrics_deployer_version in 3.4, it should have been changed to 
openshift_metrics_image_prefix and openshift_metrics_image_version in latest 3.5 installer.

2) A duplicate openshift_hosted_logging_hostname description
https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-1/inventory/byo/hosts.ose.example#L539

3) Not accurate version example for openshift_hosted_logging_deployer_version, which should be 3.5.0 in ocp-3.5 example inventory file
https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-1/inventory/byo/hosts.ose.example#L542

Comment 7 ewolinet 2017-03-16 17:18:19 UTC

(In reply to Gaoyun Pei from comment #6)
> Thanks for the quick fix on the above bugs!
> 
> After checking the logging/metrics deployment part in latest example
> inventory, add some suggestions here to make it better for customer use.
> 
> 1) Better to add description about how to specify prefix and version for
> metrics components.
> We were using openshift_hosted_metrics_deployer_prefix and
> openshift_hosted_metrics_deployer_version in 3.4, it should have been
> changed to 
> openshift_metrics_image_prefix and openshift_metrics_image_version in latest
> 3.5 installer.

We wanted to minimize the amount of disruption to customers with the transition to the new roles. They should be able to provide either to set the prefix and version. For logging we added https://github.com/openshift/openshift-ansible/blob/master/inventory/byo/hosts.origin.example#L538-L539

Would something like that be enough for Metrics as well?

> 
> 2) A duplicate openshift_hosted_logging_hostname description
> https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-
> 1/inventory/byo/hosts.ose.example#L539

What do you mean this is a duplicate?
It might be misleading that the description says 'deployer', but it is to minimize disruption. I can update that

> 
> 3) Not accurate version example for
> openshift_hosted_logging_deployer_version, which should be 3.5.0 in ocp-3.5
> example inventory file
> https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-
> 1/inventory/byo/hosts.ose.example#L542

+1

Comment 9 Gaoyun Pei 2017-03-17 02:49:20 UTC

(In reply to ewolinet from comment #7)
> (In reply to Gaoyun Pei from comment #6)
> > Thanks for the quick fix on the above bugs!
> > 
> > After checking the logging/metrics deployment part in latest example
> > inventory, add some suggestions here to make it better for customer use.
> > 
> > 1) Better to add description about how to specify prefix and version for
> > metrics components.
> > We were using openshift_hosted_metrics_deployer_prefix and
> > openshift_hosted_metrics_deployer_version in 3.4, it should have been
> > changed to 
> > openshift_metrics_image_prefix and openshift_metrics_image_version in latest
> > 3.5 installer.
> 
> We wanted to minimize the amount of disruption to customers with the
> transition to the new roles. They should be able to provide either to set
> the prefix and version. For logging we added
> https://github.com/openshift/openshift-ansible/blob/master/inventory/byo/
> hosts.origin.example#L538-L539
> 
> Would something like that be enough for Metrics as well?

That would be great.

> 
> > 
> > 2) A duplicate openshift_hosted_logging_hostname description
> > https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-
> > 1/inventory/byo/hosts.ose.example#L539
> 
> What do you mean this is a duplicate?
> It might be misleading that the description says 'deployer', but it is to
> minimize disruption. I can update that
> 

There're two openshift_hosted_logging_hostname lines
https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-1/inventory/byo/hosts.ose.example#L535
https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-1/inventory/byo/hosts.ose.example#L539


> > 
> > 3) Not accurate version example for
> > openshift_hosted_logging_deployer_version, which should be 3.5.0 in ocp-3.5
> > example inventory file
> > https://github.com/openshift/openshift-ansible/blob/openshift-ansible-3.5.35-
> > 1/inventory/byo/hosts.ose.example#L542
> 
> +1

Comment 10 Gaoyun Pei 2017-03-20 07:56:05 UTC

The latest fix wasn't merged into openshift-ansible-3.5.37-1.git.0.62660e8.el7.noarch, wait for new openshift-ansible package to verify this bug

Comment 11 ewolinet 2017-03-20 13:53:38 UTC

https://github.com/openshift/openshift-ansible/pull/3689

Comment 12 Scott Dodson 2017-03-20 14:34:55 UTC

openshift-ansible-3.5.38-1.git.0.fc961fd.el7 has all the latest commits

Comment 13 Gaoyun Pei 2017-03-21 02:07:57 UTC

Checked with openshift-ansible-3.5.39-1.git.0.cb12cdb.el7.noarch, all issues mentioned in Comment 6 have been fixed.

Comment 15 errata-xmlrpc 2017-04-12 19:02:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0903