Bug 1426565 - specifying any detail about network interfaces breaks vagrant
Summary: specifying any detail about network interfaces breaks vagrant
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vagrant-libvirt
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-24 10:32 UTC by rob.verduijn
Modified: 2017-03-07 11:28 UTC (History)
7 users (show)

Fixed In Version: vagrant-libvirt-0.0.35-3.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-07 00:50:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description rob.verduijn 2017-02-24 10:32:08 UTC
Description of problem:
assign a detail to a network card and vagrant breaks


Version-Release number of selected component (if applicable):
1.8.5-2.fc25

How reproducible:
Steps to Reproduce:
install vagrant
mkdir ~/vagranttest
cd vagranttest

create a minimal Vagrantfile
cat > Vagrantfile <<EOF
# -*- mode: ruby -*-

Vagrant.configure("2") do |config|
  config.vm.network :private_network, ip: '192.168.121.2', netmask: '255.255.255.0'
  config.vm.box = "centos/7"
end
EOF

start the vagrant machine with 'vagrant up'
and wait for it to fail


Actual results:
It fails to configure the nic

Expected results:
It should configure the nic

Additional info:
looks a bit like this one:
https://github.com/vagrant-libvirt/vagrant-libvirt/issues/645
cause if you check /etc/sysconfig/network-scripts/ifcfg-eth1 you will see the concatenated mac-addresses while /etc/sysconfig/network-scripts/ifcfg-eth0 has none

Comment 1 Vít Ondruch 2017-02-24 13:28:36 UTC
Testing this on Rawhide with vagrant-1.9.1-1.fc26 and vagrant-libvirt-0.0.37-3.fc26, I can't see any issue except of the concatenated mac-addresses in ifcfg-eth1.

Applying the patch patch from the issue you referenced, there is no mac listed in ifcfg-eth1 at all.

Anyway, this should be F25 build with the patch form the upstream ticket applied:

https://koji.fedoraproject.org/koji/taskinfo?taskID=18030137

If it works for you, I can apply it in F25.

Comment 2 Vít Ondruch 2017-02-24 14:40:29 UTC
Ok, I was able to reproduce this error on Rawhide using Vagrant 1.8.7 and vagrant-libvirt 0.37.0 and it seem the patch is fixing the issue.

Comment 3 rob.verduijn 2017-02-24 15:00:07 UTC
Hello,

After applying the patch from https://github.com/vagrant-libvirt/vagrant-libvirt/commit/5ed93bd90878166beaceaf9c88724eaac231719c

It works for me as well.

Rob Verduijn

Comment 4 rob.verduijn 2017-02-24 15:00:52 UTC
Is it supposed to create an aditional network card ?
Or is that normal behaviour ?

Rob Verduijn

Comment 5 Vít Ondruch 2017-02-24 15:19:29 UTC
I am not expert on this matter, but as far as I can tell, it should create additional card. Anyway, with this configuration I have two network interfaces with or without the patch, so I believe it does not break anything :)

Comment 6 Fedora Update System 2017-02-24 15:29:19 UTC
vagrant-libvirt-0.0.35-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0720d8dce9

Comment 7 rob.verduijn 2017-02-24 16:38:31 UTC
hi,

looking forward to the patch.


the second card is in the same subnet as the first, so unless you want to try bonding/teaming, an additional network for this card would be a wise thing.

Rob Verduijn

Comment 8 Fedora Update System 2017-02-25 01:52:54 UTC
vagrant-libvirt-0.0.35-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0720d8dce9

Comment 9 rob.verduijn 2017-02-25 18:58:05 UTC
I can't test it.
The build has failed on the lint check.

Rob Verduijn

Comment 10 Vít Ondruch 2017-02-27 10:05:08 UTC
(In reply to rob.verduijn from comment #9)
> I can't test it.
> The build has failed on the lint check.

Could you please be more specific? I am not sure if I understand your references to "build" and "lint check" ...

Comment 11 rob.verduijn 2017-02-27 12:52:41 UTC
Hello,

I followed the link to the build service to see why the rpm was not yet in testing:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0720d8dce9

On that page 
The automated build results give a fail on the test dist.rpmlint:
https://taskotron.fedoraproject.org/artifacts/all/d0820a7e-faa5-11e6-9ed0-5254008e42f6/task_output/vagrant-libvirt-0.0.35-3.fc25.log

Because the build service refused to build the rpm due to lint errors, I can't test the new rpm to see if it works.

Rob Verduijn

Comment 12 Vít Ondruch 2017-02-27 13:43:03 UTC
(In reply to rob.verduijn from comment #11)
Ah, ok, thx for explanation. 

I don't think the rpmlint is of any concern. The builds are actually done and available in the build system [1]. The limiting factory is always how quickly is the compose done and how fast are the updates propagated to the mirrors.

But doing "dnf update https://kojipkgs.fedoraproject.org//packages/vagrant-libvirt/0.0.35/3.fc25/noarch/vagrant-libvirt-0.0.35-3.fc25.noarch.rpm" should allow you to update and test in any case.

[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=861777

Comment 13 rob.verduijn 2017-03-06 19:19:49 UTC
Hello,

The rpm from updates-testing works fine for me.

Rob Verduijn

Comment 14 Fedora Update System 2017-03-07 00:50:10 UTC
vagrant-libvirt-0.0.35-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Vít Ondruch 2017-03-07 11:28:22 UTC
(In reply to rob.verduijn from comment #13)
Glad to heard that. Thank you for your feedback.


Note You need to log in before you can comment on or make changes to this bug.