Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-chaseadamsio-goorgeous.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-chaseadamsio-goorgeous-0-0.1.git054aba6.fc25.src.rpm koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18077650 Description: The purpose of this package is to come as close as possible as parsing an *.org document into HTML, the same way one might publish with org-publish-html from Emacs. Fedora Account System Username: athoscr Note that I created a dir in %{_datadir} for data needed for tests and am packaging it into the unit tests subpackage
I moved the test data to the package path, since this is the way other go packages seems to do it. See [1, 2, 3, 4] for reference. Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-chaseadamsio-goorgeous.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-chaseadamsio-goorgeous-0-0.2.git054aba6.fc25.src.rpm [1] https://jchaloup.fedorapeople.org/reviews/golang-github-prometheus-common/golang-github-prometheus-common.spec [2] https://jchaloup.fedorapeople.org/reviews/golang-github-go-ini-ini/golang-github-go-ini-ini.spec [3] https://jchaloup.fedorapeople.org/reviews/golang-github-rakyll-globalconf/golang-github-rakyll-globalconf.spec [4] https://jchaloup.fedorapeople.org/reviews/golang-github-mtrmac-gpgme/golang-github-mtrmac-gpgme.spec
Taking this review.
Created attachment 1260966 [details] fedora-review
Package looks good (full fedora-review output in the attachment). Just two minor remarks: - You *should* re-phrase the %summary to comply with the "summary-not-capitalized" rpmlint warning, for example: "ORG to HTML parser written in Go" (or something like that). Additionally, repeating the project/package name in the summary is frowned upon. - You *could* remove empty %if-%endif blocks (or ones that just contain comments) to clean up the .spec file a bit. But if you want to leave them in, that's fine (and it makes it a bit easier to fill in new dependencies if the package ever grows some in the future). Once you have decided on a "fully compliant" Summary tag, I will approve the package (you don't have to bump the spec file and rebuild the srpm, fixing it upon git import is enough).
Hi Fabio, Thank you for your review! I fixed the Summary and removed one empty conditional block as you suggested. Since I was at it, I did bump the spec and got a new srpm :) Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-chaseadamsio-goorgeous.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-chaseadamsio-goorgeous-0-0.3.git054aba6.fc25.src.rpm
Looks good!
Thank you, Fabio!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-chaseadamsio-goorgeous
golang-github-chaseadamsio-goorgeous-0-0.3.git054aba6.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43ef32dfe3
golang-github-chaseadamsio-goorgeous-0-0.3.git054aba6.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-43ef32dfe3
golang-github-chaseadamsio-goorgeous-0-0.3.git054aba6.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.