Bug 1427202 - VM doesn't start with VFIO+SR-IOV
Summary: VM doesn't start with VFIO+SR-IOV
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.18.19
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.1.2
: 4.19.11
Assignee: Martin Polednik
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-27 15:11 UTC by Martin Polednik
Modified: 2017-05-23 08:13 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Previously, if VM was started with host device AND sr-iov nic, the runtime could fail and leak the VF (render it unusable). This is now fixed and such combination of devices can be used.
Clone Of:
Environment:
Last Closed: 2017-05-23 08:13:57 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.1?
mburman: testing_plan_complete+
tjelinek: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 73162 0 master MERGED sr-iov: expose numa_node if available 2017-03-02 16:48:25 UTC
oVirt gerrit 73764 0 ovirt-4.1 MERGED network: remove is_hostdevice from __slots__ 2017-03-23 13:17:39 UTC
oVirt gerrit 73765 0 ovirt-4.1 MERGED sr-iov: expose numa_node if available 2017-03-23 13:26:40 UTC

Description Martin Polednik 2017-02-27 15:11:21 UTC 
Description of problem:
Using VFIO and SR-IOV at the same time stops VM from being booted due to network.Interface advertising itself as host device but not exposing it's numa_node.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Assign SR-IOV NIC
2. Assign some vfio-pci device
3. start the VM

Actual results:
Traceback (most recent call last):
  File "/usr/share/vdsm/virt/vm.py", line 552, in _startUnderlyingVm
    self._run()
  File "/usr/share/vdsm/virt/vm.py", line 1984, in _run
    domxml = hooks.before_vm_start(self._buildDomainXML(),
  File "/usr/share/vdsm/virt/vm.py", line 1655, in _buildDomainXML
    list(itertools.chain(*self._devices.values())))
  File "/usr/share/vdsm/virt/vmxml.py", line 785, in appendHostdevNumaTune
    dev_object.is_hostdevice and dev_object.numa_node]
AttributeError: 'Interface' object has no attribute 'numa_node'

VM doesn't start

Expected results:
VM started

Additional info:
Comment 1 Michael Burman 2017-04-27 07:35:34 UTC 
Verified on - vdsm-4.19.11-1.el7ev.x86_64 and 4.1.2-0.1.el7
Note You need to log in before you can comment on or make changes to this bug.