Bug 1427274 - Kibana header "container-brand" image should be properly branded for the deployment
Summary: Kibana header "container-brand" image should be properly branded for the depl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Logging
Version: 3.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.11.z
Assignee: Jeff Cantrill
QA Contact: Anping Li
URL:
Whiteboard:
: 1395096 1412037 1501700 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-27 18:14 UTC by Will Gordon
Modified: 2019-10-22 18:09 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-06 02:00:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift origin-aggregated-logging pull 1582 0 None None None 2019-04-02 21:01:20 UTC
Red Hat Product Errata RHBA-2019:0794 0 None None None 2019-06-06 02:00:41 UTC

Description Will Gordon 2017-02-27 18:14:24 UTC
Description of problem:
Viewing the Kibana instance for an OSD cluster deploy should be branded as OpenShift Dedicated

Version-Release number of selected component (if applicable):
OpenShift Master: v3.3.1.3
Kubernetes Master: v1.3.0+52492b4

How reproducible:
always

Steps to Reproduce:
1. Browse to https://logs.ded-int-gcp.openshift.com/#/
2. See brand image in upper left corner
3. Improperly branded for OSE

Actual results:
Improperly branded for OSE

Expected results:
OCP clusters should be branded for OCP
OSD clusters should be branded for OSD
OSO clusters should be branded for OSO


Additional info:
OCP - OpenShift Container Platform
OSD - OpenShift Dedicated
OSO - OpenShift Online

Comment 1 Jeff Cantrill 2017-02-28 00:19:40 UTC
Can you provide the proper image or point to who would have it?

Comment 3 Jeff Cantrill 2017-03-01 17:34:49 UTC
This is fixed by https://github.com/openshift/origin-aggregated-logging/pull/339 

which will allow you to provide a custom image.  I will work on some ansible changes to make this easier but until that exists:

1. Add a logging-kibana configmap: 'oc create configmap --from-file=overwrites.css=<YOURFILE>'

YOURFILE contents:

.container-brand {
  background-image: url()
}

where the url is the same as https://github.com/openshift/online/blob/master/dedicated/ui/assets/extensions/dedicated-extensions.css#L9

2. oc edit dc/logging-kibana and add:
To the kibana container:
- mountPath: /etc/openshift/kibana/styles
  name: kibana-styles
  readOnly: true

To the pod spec:
- configMap:
     name: logging-kibana
  name: kibana-styles

3. oc rollout latest dc/logging-kibana

Comment 4 Jeff Cantrill 2017-03-01 17:37:11 UTC
*** Bug 1395096 has been marked as a duplicate of this bug. ***

Comment 5 openshift-github-bot 2017-03-02 16:18:27 UTC
Commit pushed to master at https://github.com/openshift/origin-aggregated-logging

https://github.com/openshift/origin-aggregated-logging/commit/a1f7c4867f027b412a4aa4010b68ad9349332c6b
bug 1427274.  Allow users to provide override styles (e.g. header customization)

Comment 6 zhaliu 2017-03-03 05:19:53 UTC
I have checked that on online-int , ded-stg2-aws and ded-stg-gcp, the problem exists still, I think it is not ready for verification.

Comment 7 Jeff Cantrill 2017-03-03 13:32:41 UTC
Will, You will need to perform the steps from #3 to resolve this issue.

Comment 8 Jeff Cantrill 2017-03-03 13:38:01 UTC
*** Bug 1412037 has been marked as a duplicate of this bug. ***

Comment 9 Will Gordon 2017-03-03 17:16:33 UTC
This has to be done via the release-ticket tag on an issue in github (https://github.com/openshift/online/issues?q=is%3Aissue+is%3Aopen+label%3Arelease-ticket). I am not ops, I do not have control of the infrastructure.

Comment 11 Jeff Cantrill 2017-03-07 14:52:23 UTC
This is awaiting the release of the ocp images.

Comment 12 Jeff Cantrill 2017-03-07 21:43:39 UTC
12707393 buildContainer (noarch) completed successfully
koji_builds:
  https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=542659
repositories:
  brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/logging-kibana:rhaos-3.5-rhel-7-docker-candidate-20170307162508
  brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/logging-kibana:3.5.0-3
  brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/logging-kibana:3.5.0
  brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/logging-kibana:latest
  brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/logging-kibana:v3.5

Comment 13 Jeff Cantrill 2017-10-16 18:14:44 UTC
*** Bug 1501700 has been marked as a duplicate of this bug. ***

Comment 14 Anping Li 2018-08-10 09:52:40 UTC
The v3.5 is offline, Will check if the correct brand are enabled for OSO/OSD with current version.

Comment 16 Anping Li 2018-08-13 04:49:20 UTC
I couldn't change the branch following comment 3 in OCP 3.9.  I think the overwrites.css should be replaced with overrides.css.  The  overrides.css was copied to ${KIBANA_HOME}/installedPlugins/origin-kibana/public/styles. But the branch is still OpneshiftContainerPlatform.

Comment 17 Kenjiro Nakayama 2019-03-12 06:04:28 UTC
Is this feature already available on OCP 3.11?

It looks the run.sh in registry.redhat.io/openshift3/ose-logging-kibana5:v3.11.82 has the fix.
But when I have tested, the console was not updated although /usr/share/kibana/plugins/origin-kibana/public/styles/overrides.css was repalced.
I have cleaned the browser cache.

Comment 18 Kenjiro Nakayama 2019-03-13 00:53:16 UTC
@Jeff, could you please proceed this BZ? Is the status still ASSIGNED?

Comment 22 Anping Li 2019-04-16 07:45:58 UTC
The brand is Openshift Container Platform, so move to verified.

Comment 24 errata-xmlrpc 2019-06-06 02:00:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0794


Note You need to log in before you can comment on or make changes to this bug.