Bug 1427585 - Review Request: golang-github-vitrun-qart - Generator of not-so-ugly QR codes
Summary: Review Request: golang-github-vitrun-qart - Generator of not-so-ugly QR codes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1427634
TreeView+ depends on / blocked
 
Reported: 2017-02-28 16:42 UTC by Fabio Valentini
Modified: 2017-04-10 21:41 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-04-10 21:41:03 UTC
Type: ---
Embargoed:
jchaloup: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2017-02-28 16:42:43 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-vitrun-qart.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-vitrun-qart-0.1-1.fc25.src.rpm

Description: Generator of not-so-ugly QR codes

Fedora Account System Username: decathorpe


koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18109551


PS: The .spec file was generated by gofed, but modified to use the latest stable release of the go package in question (since it has a real release on github). Tests pass on all arches (see successful koji build).

Comment 1 Jan Chaloupka 2017-03-01 12:03:15 UTC
The license id BSD. Though there are both (ASL 2.0 and BSD), *.go files refer to the BSD. Otherwise LGTM. Once the license is fixed, I will approve.

Comment 2 Jan Chaloupka 2017-03-01 12:06:56 UTC
If possible, please, keep the
%global commit bf64b92db6b05651d6c25a3dabf2d543b360c0aa
macro in the spec. It is used by gofed tooling to associate your spec file with upstream commit.

Comment 3 Fabio Valentini 2017-03-01 13:49:36 UTC
License tag is fixed, and %commit and %shortcommit are back. Same links.

Comment 4 Gwyn Ciesla 2017-03-01 16:09:57 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-vitrun-qart


Note You need to log in before you can comment on or make changes to this bug.