Bug 1427765

This bugzilla has been removed from the release and needs to be reviewed and Triaged for another Target Release.

Elise, Thanks for the confirmation.

(In reply to Nilesh from comment #0)
> Description of problem:
> 
> In order to automate this command


Which command? I have no idea what this bug is about.

Hello, 

There is no command as of now for Glance to automate this feature. 


As en example have a look below for Keystone and Nova :- 

++++++++++++++++++++++++++++
Identity Service (Keystone)
++++++++++++++++++++++++++++

~~~~~~~~~~
/usr/bin/keystone-manage token_flush

Example: 0 */1 * * * /usr/bin/keystone-manage token_flush >/dev/null 2>&1
~~~~~~~~~~

++++++++++++++++++++++++++++
Compute Service (Nova)
++++++++++++++++++++++++++++

~~~~~~~~~~
/usr/bin/nova-manage db archive_deleted_rows

Example: 0 */12 * * * /usr/bin/nova-manage db archive_deleted_rows >/dev/null 2>&1
~~~~~~~~~~


In the same manner thinking about Glance, if we can achieve this as Customer is specifically asking for Glance. 



++++++++++++++++++++++++++++
Image Service (Glance)
++++++++++++++++++++++++++++

~~~~~~~~~~
Glance also makes use of “soft-deleted” rows, however currently these can only be removed using manual SQL commands or custom scripting. 
~~~~~~~~~~

So, isn't this the functionality provided by "glance-manage db purge"?

I am not very much sure, but Yes, its provided by "glance-manage db purge"


we want a way to automate this command, it should run within the scope of a cron job on at least an hourly basis. And this should automatically build during Director installation.

(In reply to Nilesh from comment #6)
> I am not very much sure, but Yes, its provided by "glance-manage db purge"
> 
> 
> we want a way to automate this command, it should run within the scope of a
> cron job on at least an hourly basis. And this should automatically build
> during Director installation.

This feature was recently added to glance in RHOS11. The following command will delete any rows from glance DB of images records that was deleted from the system. 
# glance-manage db purge --age_in_days 0

Can we have the same functionality on OSP9 as well.

So Avi says "glance-manage db purge" is new in OSP11, but I think it was already there in OSP9 (Mitaka): https://github.com/openstack/glance/blob/stable/mitaka/glance/cmd/manage.py#L154 . What is new in OSP11 is the ability to purge rows created less than a day ago.

@Nilesh: Could you try this feature and tell us whether it is what you're looking for? If so, we could ask the triple-o team if it would make sense to add a call to this command in the crontab.

hello Cyril, 

Could you please share exact command to purge so I can try on my packstack setup to test it.

Sure, you could try:

glance-manage db purge --age_in_days 1

I recommend to to run the following command 
# glance-manage db purge --age_in_days 0
running "--age_in_days 1" will delete rows created 24 hours ago so it is not logical to run hourly .

Hello Avi, 

Running "glance-manage --debug db purge --age_in_days 0"

Got bellow output :- 

Option "verbose" from group "DEFAULT" is deprecated for removal.  Its value may be silently ignored in the future.
Must supply a positive, non-zero value for age.
You have new mail in /var/spool/mail/root


And running "glance-manage --debug db purge --age_in_days 1"

Got :- 

Option "verbose" from group "DEFAULT" is deprecated for removal.  Its value may be silently ignored in the future.
/usr/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:1171: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade
  expire_on_commit=expire_on_commit, _conf=conf)



Can we automate this command, it should run within the scope of a cron job on at least an hourly basis. And this should automatically build during Director installation.

Master bug already open for other components as well. 

https://bugzilla.redhat.com/show_bug.cgi?id=1399026

https://bugzilla.redhat.com/show_bug.cgi?id=1427766

@Avi: I think that "0" can only be passed in OSP11 :)

@Nilesh: why "at least on an hourly basis"? Why wouldn't it be OK to run this once a day? Anyway, I think this should be retargeted to triple-o, since this is where the cron entry should be added. WDYT?

@Cyril, Yeah agree with you,  It should be once a day.

Avi,
Can we please test it in OSP12 and report actual status in this release?
Sean

(In reply to Sean Cohen from comment #16)
> Avi,
> Can we please test it in OSP12 and report actual status in this release?
> Sean

Just to be clear. Do I need to test if the feature works on RHOS12 or if it's can be run as schedule task ?

I agree with Avi. This feature is currently being tested in OSP11. Adding a cron entry is a job for triple-o, or should be done by the user. There is not much to test here: we know that "cron" works well, and the "db purge" feature is already being taken care of.

Thanks @Avi and @Cyril, Customer is curious to add this cron automatically during director installation.

We could convert this to an OOO bug that would be assigned to Erno, but I still think it is not a really good idea. Most users probably do not want that. Nilesh's customer should ask their own sysadmins to add the cron entry. Or maybe this could somehow be disabled by default?

Good points.  I think the full context in the the original bug filed on multiple components https://bugzilla.redhat.com/show_bug.cgi?id=1399026 

I like the disabled by default idea.