Bug 1427835 - Terminator fails with "TypeError: argument window: Expected GdkX11.X11Window, but got __gi__.GdkWaylandWindow"
Summary: Terminator fails with "TypeError: argument window: Expected GdkX11.X11Window,...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: terminator
Version: 25
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Dominic Hopf
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1428304 1428374 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-01 11:08 UTC by Nitin Kumar Bansal
Modified: 2017-03-03 12:28 UTC (History)
8 users (show)

Fixed In Version: terminator-1.91-2.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-03 03:55:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Nitin Kumar Bansal 2017-03-01 11:08:13 UTC
Description of problem:
Terminator fails to launch since upgrading to terminator-1.91-1.fc25.noarch:

$ terminator
(terminator:30796): Gtk-WARNING **: Allocating size to GtkVScrollbar 0x55c2e06bc650 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
Traceback (most recent call last):
  File "/usr/bin/terminator", line 126, in <module>
    TERMINATOR.layout_done()
  File "/usr/lib/python2.7/site-packages/terminatorlib/terminator.py", line 402, in layout_done
    t = GdkX11.x11_get_server_time(window.get_window())
TypeError: argument window: Expected GdkX11.X11Window, but got __gi__.GdkWaylandWindow

Version-Release number of selected component (if applicable):
terminator-1.91-1.fc25.noarch

How reproducible:
Always

Steps to Reproduce:
1. Try to launch terminator, it fails with the error given in description.

Actual results:
Terminator fails to launch

Expected results:
Terminator should launch

Additional info:

Comment 1 Nitin Kumar Bansal 2017-03-01 11:10:56 UTC
Looks same as https://bugs.launchpad.net/terminator/+bug/1668481

Comment 2 Nitin Kumar Bansal 2017-03-01 11:17:05 UTC
wayland_fix.diff from comment #3 fixed the issue.

Comment 3 Mike 2017-03-01 21:11:43 UTC
Seeing this error as well. I just upgraded the package today 3/1/17, looks like an update was released for this package either on 2/27/17 or 2/28/17.

Here is the error message I'm seeing:  

Mar 01 15:09:10 blah.name terminator[5461]: Allocating size to GtkVScrollbar 0x562ba4ade650 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?
Mar 01 15:09:10 blah.name terminator.desktop[5461]: Traceback (most recent call last):
Mar 01 15:09:10 blah.name terminator.desktop[5461]:   File "/usr/bin/terminator", line 126, in <module>
Mar 01 15:09:10 blah.name terminator.desktop[5461]:     TERMINATOR.layout_done()
Mar 01 15:09:10 blah.name terminator.desktop[5461]:   File "/usr/lib/python2.7/site-packages/terminatorlib/terminator.py", line 402, in layout_done
Mar 01 15:09:10 blah.name terminator.desktop[5461]:     t = GdkX11.x11_get_server_time(window.get_window())
Mar 01 15:09:10 blah.name terminator.desktop[5461]: TypeError: argument window: Expected GdkX11.X11Window, but got __gi__.GdkWaylandWindow

Comment 4 Matt Rose 2017-03-01 21:15:05 UTC
Hopefully I'll be able to fix this up tonight.  Should just be a matter of taking the patch from launchpad and applying it to the rpm.

Comment 5 Matt Rose 2017-03-01 21:18:03 UTC
Hah, upstream has released a new version that fixes this.  I'll see if I can push this out tonight EST.

Comment 6 Mike 2017-03-01 21:18:17 UTC
Yeah, I was just going to confirm that the patch that Nitin Bansal mentioned, did work for my release as well. Purely as an FYI.

Comment 7 Fedora Update System 2017-03-02 04:54:17 UTC
terminator-1.91-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e11859cc5

Comment 8 Matt Rose 2017-03-02 04:58:08 UTC
Should fix it.  I reproduced the issue and then built and installed the new package, and didn't see the issue.

I hope everyone appreciates me doing this instead of going to bed at a decent hour :)

Comment 9 Nitin Kumar Bansal 2017-03-02 05:14:49 UTC
(In reply to Matt Rose from comment #8)
> Should fix it.  I reproduced the issue and then built and installed the new
> package, and didn't see the issue.
> 
> I hope everyone appreciates me doing this instead of going to bed at a
> decent hour :)

Definitely, thank you for speedy resolution. matt++ :)

Comment 10 Matt Rose 2017-03-02 14:01:08 UTC
*** Bug 1428374 has been marked as a duplicate of this bug. ***

Comment 11 Fedora Update System 2017-03-03 03:55:30 UTC
terminator-1.91-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 James Hogarth 2017-03-03 12:28:06 UTC
*** Bug 1428304 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.