Bug 1427883 – CRL loading leaks memory

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1427883 - CRL loading leaks memory

Summary:	CRL loading leaks memory

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	curl (Show other bugs)
Sub Component:
Version:	7.3
Hardware:	All Linux

Priority	medium Severity low
Target Milestone:	alpha
Target Release:	7.5
Assigned To:	Kamil Dudka
QA Contact:	Stefan Dordevic
Docs Contact:

URL:
Whiteboard:
Keywords:	Patch, Reproducer

Depends On:
Blocks:	1465901
	Show dependency tree / graph

Reported:	2017-03-01 08:04 EST by Kamil Dudka
Modified:	2018-04-10 07:46 EDT (History)
CC List:	2 users (show)

See Also:
Fixed In Version:	curl-7.29.0-44.el7
Doc Type:	No Doc Update
Doc Text:	undefined
Story Points:	---
Clone Of:
Environment:
Last Closed:	2018-04-10 07:45:43 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2018:0732	None	None	None	2018-04-10 07:46 EDT

Groups: None (edit)

Description Kamil Dudka 2017-03-01 08:04:18 EST

Description of problem:
Since nss-pem was introduced in RHEL-7, curl upstream test 313 started to detect memory leakage while loading CRL.  The memory leak has always been there.  It only used to be hidden due to unrelated bug in tests/valgrind.pm which has already been removed upstream:

https://github.com/curl/curl/commit/curl-7_52_0-6-g5c823f5


Version-Release number of selected component (if applicable):
curl-7.29.0-39.el7


Steps to Reproduce:
1. run the upstream test 313 under valgrind


Actual results:
487 bytes in 1 blocks are definitely lost in loss record 20 of 25
   at 0x4C2DB9D: malloc (vg_replace_malloc.c:299)
   by 0x585578D: PORT_Alloc_Util (in /usr/lib64/libnssutil3.so)
   by 0x58541E6: SECITEM_AllocItem_Util (in /usr/lib64/libnssutil3.so)
   by 0x584DE45: NSSBase64_DecodeBuffer_Util (in /usr/lib64/libnssutil3.so)
   by 0x584E016: ATOB_ConvertAsciiToItem_Util (in /usr/lib64/libnssutil3.so)
   by 0x4E7C318: nss_load_crl (nss.c:533)
   by 0x4E7C318: nss_setup_connect (nss.c:1464)
   by 0x4E7C318: nss_connect_common (nss.c:1630)
   by 0x4E72ED9: Curl_ssl_connect_nonblocking (sslgen.c:229)
   by 0x4E4A3CC: https_connecting (http.c:1345)
   by 0x4E4A3CC: Curl_http_connect (http.c:1315)
   by 0x4E59F3B: Curl_protocol_connect (url.c:3291)
   by 0x4E6D6E8: multi_runsingle (multi.c:1163)
   by 0x4E6DBB0: curl_multi_perform (multi.c:1753)
   by 0x4E64F3A: curl_easy_perform (easy.c:480)
   by 0x117BEE: operate (tool_operate.c:1362)
   by 0x10E087: main (tool_main.c:107)


Additional info:
The following upstream patches fix the memory leakage:

https://github.com/curl/curl/commit/curl-7_37_1~34
https://github.com/curl/curl/commit/curl-7_37_1~33
https://github.com/curl/curl/commit/curl-7_37_1~32
https://github.com/curl/curl/commit/curl-7_37_1~31
https://github.com/curl/curl/commit/curl-7_39_0~165

Comment 9 errata-xmlrpc 2018-04-10 07:45:43 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0732

Note You need to log in before you can comment on or make changes to this bug.