Spec URL: https://gil.fedorapeople.org/aries-spifly.spec SRPM URL: https://gil.fedorapeople.org/aries-spifly-1.0.8-1.fc24.src.rpm Description: The SPI Fly component is aimed at providing OSGi support for JRE SPI mechanisms, including the usage of java.util.ServiceLoader, META-INF/services and similar methods. SPI Fly is the Reference Implementation of the OSGi ServiceLoader Mediator specification, chapter 133 in the OSGi Enterprise Specification, available from version 5. Fedora Account System Username: gil Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=18125710
Spec URL: https://gil.fedorapeople.org/aries-spifly.spec SRPM URL: https://gil.fedorapeople.org/aries-spifly-1.0.8-1.fc25.src.rpm
The SRPM is 404. Because the package uses only upstream sources, I believe it's not needed for the review and I based the review just on the spec. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 18 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/spifly/review-aries-spifly/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in aries- spifly-core-internal , aries-spifly-dynamic-bundle , aries-spifly- javadoc , aries-spifly-static-bundle , aries-spifly-static-tool , aries-spifly-weaver-internal [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [ ]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: aries-spifly-1.0.8-1.fc27.noarch.rpm aries-spifly-core-internal-1.0.8-1.fc27.noarch.rpm aries-spifly-dynamic-bundle-1.0.8-1.fc27.noarch.rpm aries-spifly-javadoc-1.0.8-1.fc27.noarch.rpm aries-spifly-static-bundle-1.0.8-1.fc27.noarch.rpm aries-spifly-static-tool-1.0.8-1.fc27.noarch.rpm aries-spifly-weaver-internal-1.0.8-1.fc27.noarch.rpm aries-spifly-1.0.8-1.fc27.src.rpm aries-spifly.noarch: W: spelling-error %description -l en_US util -> til, until, u til aries-spifly.noarch: W: spelling-error %description -l en_US ServiceLoader -> Service Loader, Service-loader, Serviceable aries-spifly.noarch: W: no-documentation aries-spifly-core-internal.noarch: W: no-documentation aries-spifly-dynamic-bundle.noarch: W: no-documentation aries-spifly-static-bundle.noarch: W: spelling-error %description -l en_US apache -> Apache, apace aries-spifly-static-bundle.noarch: W: no-documentation aries-spifly-static-tool.noarch: W: no-documentation aries-spifly-weaver-internal.noarch: W: no-documentation aries-spifly.src: W: spelling-error %description -l en_US util -> til, until, u til aries-spifly.src: W: spelling-error %description -l en_US ServiceLoader -> Service Loader, Service-loader, Serviceable 8 packages and 0 specfiles checked; 0 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory aries-spifly-static-tool.noarch: W: no-documentation aries-spifly-dynamic-bundle.noarch: W: no-documentation aries-spifly-static-bundle.noarch: W: spelling-error %description -l en_US apache -> Apache, apace aries-spifly-static-bundle.noarch: W: no-documentation aries-spifly-core-internal.noarch: W: no-documentation aries-spifly-weaver-internal.noarch: W: no-documentation aries-spifly.noarch: W: spelling-error %description -l en_US util -> til, until, u til aries-spifly.noarch: W: spelling-error %description -l en_US ServiceLoader -> Service Loader, Service-loader, Serviceable aries-spifly.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 9 warnings. Requires -------- aries-spifly-static-tool (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.aries.spifly:org.apache.aries.spifly.core-internal) mvn(org.apache.aries.spifly:org.apache.aries.spifly.weaver-internal) mvn(org.eclipse.osgi:org.eclipse.osgi) mvn(org.ow2.asm:asm-debug-all) aries-spifly-dynamic-bundle (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.aries.spifly:org.apache.aries.spifly.core-internal) mvn(org.apache.aries.spifly:org.apache.aries.spifly.weaver-internal) mvn(org.ow2.asm:asm-debug-all) aries-spifly-static-bundle (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.aries.spifly:org.apache.aries.spifly.core-internal) aries-spifly-core-internal (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.aries:org.apache.aries.util) aries-spifly-weaver-internal (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.apache.aries.spifly:org.apache.aries.spifly.core-internal) aries-spifly (rpmlib, GLIBC filtered): java-headless javapackages-tools aries-spifly-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- aries-spifly-static-tool: aries-spifly-static-tool mvn(org.apache.aries.spifly:org.apache.aries.spifly.static.tool) mvn(org.apache.aries.spifly:org.apache.aries.spifly.static.tool:pom:) osgi(org.apache.aries.spifly.static.tool) aries-spifly-dynamic-bundle: aries-spifly-dynamic-bundle mvn(org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle) mvn(org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:pom:) osgi(org.apache.aries.spifly.dynamic.bundle) aries-spifly-static-bundle: aries-spifly-static-bundle mvn(org.apache.aries.spifly:org.apache.aries.spifly.static.bundle) mvn(org.apache.aries.spifly:org.apache.aries.spifly.static.bundle:pom:) osgi(org.apache.aries.spifly.static.bundle) aries-spifly-core-internal: aries-spifly-core-internal mvn(org.apache.aries.spifly:org.apache.aries.spifly.core-internal) mvn(org.apache.aries.spifly:org.apache.aries.spifly.core-internal:pom:) osgi(org.apache.aries.spifly.core-internal) aries-spifly-weaver-internal: aries-spifly-weaver-internal mvn(org.apache.aries.spifly:org.apache.aries.spifly.weaver-internal) mvn(org.apache.aries.spifly:org.apache.aries.spifly.weaver-internal:pom:) osgi(org.apache.aries.spifly.weaver-internal) aries-spifly: aries-spifly mvn(org.apache.aries.spifly:spifly:pom:) aries-spifly-javadoc: aries-spifly-javadoc Source checksums ---------------- http://central.maven.org/maven2/org/apache/aries/spifly/spifly/1.0.8/spifly-1.0.8-source-release.zip : CHECKSUM(SHA256) this package : c6452ff6ffbb2dcebe621c9ccb4dfbd60b26553ca1e841f617116dacd946b7bf CHECKSUM(SHA256) upstream package : c6452ff6ffbb2dcebe621c9ccb4dfbd60b26553ca1e841f617116dacd946b7bf Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n aries-spifly Buildroot used: rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Looks ok to me. APPROVED
The package was still not requested to be added to Fedora. If there's no response within a week I'll close this review as stalled.