Bug 1428050 - performance/md-cache: Fix caching for root inode
Summary: performance/md-cache: Fix caching for root inode
Keywords:
Status: CLOSED DUPLICATE of bug 1404442
Alias: None
Product: GlusterFS
Classification: Community
Component: md-cache
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-01 19:04 UTC by Vijay Bellur
Modified: 2017-04-18 20:09 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
831/
Last Closed: 2017-04-18 20:09:59 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijay Bellur 2017-03-01 19:04:46 UTC
performance/md-cache: Fix caching for root inode

Summary:
- `is_mdc_key_satisfied()` is returning 0 when it has not checked any of the keys
- This causes the cache'd value for the root inode to always be invalid (`mdc_xattr_satisfied()` returns 0, which causes us to jump to `uncached').
- In this diff we add a new option called "strict-xattrs", when enabled winds getxattr calls for those keys not present in our cache.
- This allows "special" getxattr commands (quota cli commands for example) to work when md-cache is enabled.
- This is a port of D4135452

Test Plan:
- Test on devserver and see latency improvements for root inode.
- Prove tests

Signed-off-by: Shreyas Siravara <sshreyas>

Change-Id: I8ff75595e821d7a714224b3b3dded23f0a93560a
Reviewed-on: http://review.gluster.org/16060
Smoke: Gluster Build System <jenkins.org>
CentOS-regression: Gluster Build System <jenkins.org>
Reviewed-by: Kevin Vigor <kvigor>
Tested-by: Shreyas Siravara <sshreyas>
NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 1 Worker Ant 2017-03-02 20:26:07 UTC
REVIEW: https://review.gluster.org/16831 (performance/md-cache: Fix caching for root inode) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 2 Vijay Bellur 2017-04-18 20:09:59 UTC

*** This bug has been marked as a duplicate of bug 1404442 ***


Note You need to log in before you can comment on or make changes to this bug.