Bug 1428064 - nfs: Check for null buf, and set op_errno to EIO not 0
Summary: nfs: Check for null buf, and set op_errno to EIO not 0
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: nfs
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-01 19:05 UTC by Vijay Bellur
Modified: 2017-05-30 18:46 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-30 18:46:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijay Bellur 2017-03-01 19:05:30 UTC
nfs: Check for null buf, and set op_errno to EIO not 0

Summary:
- Prevent crashes for the case where "getattr" actually failed and
  returned with a NULL buf, but the op_errno was set to 0.
- This is a cherry-pick of D1571184

Signed-off-by: Shreyas Siravara <sshreyas>
Change-Id: Ia2d6ad7539df714f9420dcf063c7c14e727bb7e3
Reviewed-on: http://review.gluster.org/16152
Smoke: Gluster Build System <jenkins.org>
NetBSD-regression: NetBSD Build System <jenkins.org>
CentOS-regression: Gluster Build System <jenkins.org>
Reviewed-by: Kevin Vigor <kvigor>

Comment 1 Worker Ant 2017-03-01 20:12:27 UTC
REVIEW: https://review.gluster.org/16803 (nfs: Check for null buf, and set op_errno to EIO not 0) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 2 Worker Ant 2017-04-26 23:31:53 UTC
COMMIT: https://review.gluster.org/16803 committed in master by Jeff Darcy (jeff.us) 
------
commit 3579aaaef0027c62bad57952e433e15fa9f1532c
Author: Richard Wareing <rwareing>
Date:   Mon Sep 22 17:42:04 2014 -0700

    nfs: Check for null buf, and set op_errno to EIO not 0
    
    Summary:
    - Prevent crashes for the case where "getattr" actually failed and
      returned with a NULL buf, but the op_errno was set to 0.
    - This is a cherry-pick of D1571184
    
    Signed-off-by: Shreyas Siravara <sshreyas>
    Change-Id: Ia2d6ad7539df714f9420dcf063c7c14e727bb7e3
    BUG: 1428064
    Reviewed-on: http://review.gluster.org/16152
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kevin Vigor <kvigor>
    Reviewed-on: https://review.gluster.org/16803
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Jeff Darcy <jeff.us>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 3 Shyamsundar 2017-05-30 18:46:32 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.