Description of problem: - CFME 4.2(CFME 5.7.0.17) - Service requests show "refresh" buttons instead of values - The "Dialog Options" section shows the value "<None>", with the "Refresh" button next to it, and not the value that the user selected. - The "Dialog Options" section shows the values that the user selected from the service dialog Version-Release number of selected component (if applicable): CFME 4.2(CFME 5.7.0.17) How reproducible: Steps to Reproduce: (1) Create a service dialog with a dynamic drop-down, and add a "refresh" button (2) Create a service catalog item that uses the dialog (3) Request the service from the catalog, select "refresh" for each drop-down, and select the value. (4) Submit the catalog item. (5) Select "Services" -> "Requests", and select the new request Actual results: The "Dialog Options" section shows the value "<None>", with the "Refresh" button next to it, and not the value that the user selected Expected results: The "Dialog Options" section shows the values that the user selected from the service dialog Additional info: In case service dialog use a careful combination of "auto-refresh" and "refresh others", that is "don't use manual refresh" anywhere, the issue goes away. but this can't be an option for this business purpose.
Dan, this looks to be classic UI not service UI. Sending to you. If I am wrong, please feel free to send back :)
Erik - This is happening on the static view of the dialog when looking at the request. Would suggest reaching out to Harpreet if you need help on this.
Hi Taeho, yeah, it looks to just be a UI issue, the actual data that is sent is correct. The logic currently instead of just supplying the UI with the correct values it is running through a lot of extraneous steps and is actually causing the dialog to go through a fake run. I'm working on decoupling this implementation.
https://github.com/ManageIQ/manageiq/pull/14219
https://github.com/ManageIQ/manageiq-ui-classic/pull/614
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/ff6d20cc3a50b51e6dfc5eb7059c750909a1df9c commit ff6d20cc3a50b51e6dfc5eb7059c750909a1df9c Author: Erik Clarizio <eclarizi> AuthorDate: Tue Mar 7 09:18:07 2017 -0800 Commit: Erik Clarizio <eclarizi> CommitDate: Tue Mar 7 10:11:12 2017 -0800 Use given values when running through a dialog for a request review https://bugzilla.redhat.com/show_bug.cgi?id=1428171 app/models/dialog.rb | 6 ++++++ app/models/resource_action_workflow.rb | 10 ++++++--- spec/models/dialog_spec.rb | 23 ++++++++++++++++++++ spec/models/resource_action_workflow_spec.rb | 32 ++++++++++++++++++++++++++++ 4 files changed, 68 insertions(+), 3 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/80f76e92065ea47a3ae24cc5a11dbfc10e74ebcf commit 80f76e92065ea47a3ae24cc5a11dbfc10e74ebcf Author: Erik Clarizio <eclarizi> AuthorDate: Wed Mar 8 08:38:45 2017 -0800 Commit: Erik Clarizio <eclarizi> CommitDate: Wed Mar 8 08:47:33 2017 -0800 Change 'request_view' option to 'display_view_only' https://bugzilla.redhat.com/show_bug.cgi?id=1428171 app/models/resource_action_workflow.rb | 2 +- spec/models/resource_action_workflow_spec.rb | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/133a3f5a2a088dbefc9db3b440c67383fee7da28 commit 133a3f5a2a088dbefc9db3b440c67383fee7da28 Author: Erik Clarizio <eclarizio> AuthorDate: Tue Mar 7 09:18:59 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Tue Mar 7 09:18:59 2017 -0800 Utilize new option "request_view" to force values to be used in review https://bugzilla.redhat.com/show_bug.cgi?id=1428171 app/views/miq_request/_st_prov_show.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/0d59c183650db6fdece9ac9b288267821b608a6b commit 0d59c183650db6fdece9ac9b288267821b608a6b Author: Erik Clarizio <eclarizio> AuthorDate: Tue Mar 7 14:35:53 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Wed Mar 8 08:46:20 2017 -0800 Use "<None>" for a nil drop down, otherwise the supplied value https://bugzilla.redhat.com/show_bug.cgi?id=1428171 app/views/shared/dialogs/_dialog_field_drop_down_list.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/cea90f0498cba305fa4545b7b6e6441dd2eb8cc3 commit cea90f0498cba305fa4545b7b6e6441dd2eb8cc3 Author: Erik Clarizio <eclarizio> AuthorDate: Wed Mar 8 08:38:13 2017 -0800 Commit: Erik Clarizio <eclarizio> CommitDate: Wed Mar 8 08:47:20 2017 -0800 Change 'request_view' option to 'display_view_only' https://bugzilla.redhat.com/show_bug.cgi?id=1428171 app/views/miq_request/_st_prov_show.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Clearing needsinfo since this is past POST and ON_QA
Fixed . Verified in 5.8.0.12-rc1.20170425180304_4f35996