RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1428209 - When only parent wwnn(or wwpn) provided to create a npiv pool, libvirt should report an error like nodedev-create does
Summary: When only parent wwnn(or wwpn) provided to create a npiv pool, libvirt should...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.4
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: John Ferlan
QA Contact: yisun
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-02 02:07 UTC by yisun
Modified: 2017-08-02 00:03 UTC (History)
5 users (show)

Fixed In Version: libvirt-3.2.0-1.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 17:24:15 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1846 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2017-08-01 18:02:50 UTC

Description yisun 2017-03-02 02:07:03 UTC 
Description of problem:
When only parent wwnn(or wwpn) provided to create a npiv pool, libvirt should report an error like nodedev-create does

Version-Release number of selected component (if applicable):
libvirt-3.0.0-2.el7.x86_64
qemu-kvm-rhev-2.8.0-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare the pool's xml, which only contains parent's wwnn (or wwpn) info
## cat pool.xml
<pool type='scsi'>
  <name>virt-pool</name>
  <source>
    <adapter type='fc_host' parent_wwnn='2000000000000000' managed='yes' wwnn='20000000c99e2b80' wwpn='1000000000000001'/>
  </source>
  <target>
    <path>/dev/disk/by-path</path>
  </target>
</pool>

2. create the pool
## virsh pool-create pool.xml
Pool virt-pool created from pool.xml

<==== here is the problem, libvirt doesn't check if both parent's wwnn and wwpn exist, and create pool based on the first available HBA.


Actual results:
Pool successfully created

Expected results:
Should report error like nodedev-create does:
error: XML error: must supply both wwnn and wwpn for parent

Additional info:
This issue is separated from bz 1349696
Comment 2 John Ferlan 2017-03-10 21:31:45 UTC 
I posted a patch upstream as part of a larger series that should resolve this problem:

http://www.redhat.com/archives/libvir-list/2017-March/msg00476.html
Comment 5 yisun 2017-04-06 07:51:29 UTC 
Verified on libvirt-3.2.0-1.el7.x86_64

1. only provide parent wwnn
## cat pool.xml 
<pool type='scsi'>
  <name>virt-pool</name>
  <source>
    <adapter type='fc_host' parent_wwnn='2000000000000000' managed='yes' wwnn='20000000c99e2b80' wwpn='1000000000000001'/>
  </source>
  <target>
    <path>/dev/disk/by-path</path>
  </target>
</pool>

## virsh pool-define pool.xml 
error: Failed to define pool from pool.xml
error: XML error: when providing parent_wwnn='2000000000000000', the parent_wwpn must also be provided

## virsh pool-create pool.xml 
error: Failed to create pool from pool.xml
error: XML error: when providing parent_wwnn='2000000000000000', the parent_wwpn must also be provided

2. only provide parent wwpn
## cat pool.xml 
<pool type='scsi'>
  <name>virt-pool</name>
  <source>
    <adapter type='fc_host' parent_wwpn='2000000000000000' managed='yes' wwnn='20000000c99e2b80' wwpn='1000000000000001'/>
  </source>
  <target>
    <path>/dev/disk/by-path</path>
  </target>
</pool>


## virsh pool-define pool.xml 
error: Failed to define pool from pool.xml
error: XML error: when providing parent_wwpn='2000000000000000', the parent_wwnn must also be provided

## virsh pool-create pool.xml 
error: Failed to create pool from pool.xml
error: XML error: when providing parent_wwpn='2000000000000000', the parent_wwnn must also be provided
Comment 6 errata-xmlrpc 2017-08-01 17:24:15 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Comment 7 errata-xmlrpc 2017-08-02 00:03:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Note You need to log in before you can comment on or make changes to this bug.